Skip to content

[chore] Create an event registry #2382 #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Jul 2, 2025

Progresses #2382

Changes

This introduces an event registry to reside alongside the attributes registry and the soon to be released entities registry. This provides pure code generated documentation for events which reduces maintenance effort and makes things more discoverable.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@thompson-tomo thompson-tomo requested a review from a team as a code owner July 2, 2025 05:11
@thompson-tomo thompson-tomo requested review from a team as code owners July 2, 2025 05:11
@thompson-tomo thompson-tomo force-pushed the feature/#2382_AddEventRegistry branch 3 times, most recently from 06aaa4a to d1c802d Compare July 2, 2025 06:13
@thompson-tomo thompson-tomo force-pushed the feature/#2382_AddEventRegistry branch 5 times, most recently from dc0d7d5 to 9414d75 Compare July 12, 2025 08:35
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
@thompson-tomo thompson-tomo force-pushed the feature/#2382_AddEventRegistry branch from 9414d75 to e21445d Compare July 12, 2025 08:39

# {{ ctx.namespace | title_case | acronym }}

{%- if ctx.entities | length > 0 %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are entities in the event namespace?

Copy link
Contributor Author

@thompson-tomo thompson-tomo Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to get this index page to show all the signal types grouped by type but was stuck on the filter hence my other comment (#2464 (comment)). That way a user could go to the rpc index page and see all attributes, events, log records, metrics & spans.

application_mode: single
file_name: 'events/README.md'
- pattern: event_namespace.md.j2
filter: '.groups | map(select(.type | startswith("event"))) | group_by(.name | split(".") | .[0]) | map({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to eventually find a way to get rid of the startsWith

Comment on lines +19 to +23
<tr>
<th>Namespace</th>
<th>Event</th>
<th>Stability</th>
</tr>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to see this as a table with a count of items per signal type which is linked to the section especially if we combine based on namespace.

@jsuereth
Copy link
Contributor

A few thoughts on this:

  • Can you comment on why each event is its own markdown file? I think this is likely the right way forward but want to be explicit as we move forward on signals. It is not what we did for Entity.
  • Can you add a link to the Event registry from the registry/README.md file?
  • Can you modify this to pull in every event without using startswith. I think you had at one time split logrecord vs. event. We do not want that distinction going forward, so this should just grab all group.type=event.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Jul 14, 2025

Thanks for the feedback @jsuereth

Can you comment on why each event is its own markdown file? I think this is likely the right way forward but want to be explicit as we move forward on signals. It is not what we did for Entity.

Reason for 1 page per signal definition is so that we could have a namespace index page which would hopefully list everything in that namespace be it events, log records, metrics, spans etc. If we have 1 page it quickly grows out of hand and this approach is inline with the proposal to update the metric layout.

Can you add a link to the Event registry from the registry/README.md file?

Yes can do

Can you modify this to pull in every event without using startswith. I think you had at one time split logrecord vs. event. We do not want that distinction going forward, so this should just grab all group.type=event.

If possible I would get rid of the starts with altogether and just do filtering on the last mapping and is what is required for the general namespace page.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Jul 14, 2025

@jsuereth Following on from the semconv meeting, I will do the following:

  • Raise a seperate pr to introduce the namespace index page as seen here so it can be used for entities.
  • Add entities to the namespace index page & dedicated pages
  • Allow this PR to focus on adding events to the registry
  • Work through existing event pages inspecting what has been migrated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants