-
Notifications
You must be signed in to change notification settings - Fork 245
[chore] Create an event registry #2382 #2464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[chore] Create an event registry #2382 #2464
Conversation
06aaa4a
to
d1c802d
Compare
dc0d7d5
to
9414d75
Compare
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
9414d75
to
e21445d
Compare
|
||
# {{ ctx.namespace | title_case | acronym }} | ||
|
||
{%- if ctx.entities | length > 0 %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are entities in the event namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping to get this index page to show all the signal types grouped by type but was stuck on the filter hence my other comment (#2464 (comment)). That way a user could go to the rpc index page and see all attributes, events, log records, metrics & spans.
application_mode: single | ||
file_name: 'events/README.md' | ||
- pattern: event_namespace.md.j2 | ||
filter: '.groups | map(select(.type | startswith("event"))) | group_by(.name | split(".") | .[0]) | map({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to eventually find a way to get rid of the startsWith
<tr> | ||
<th>Namespace</th> | ||
<th>Event</th> | ||
<th>Stability</th> | ||
</tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to see this as a table with a count of items per signal type which is linked to the section especially if we combine based on namespace.
A few thoughts on this:
|
Thanks for the feedback @jsuereth
Reason for 1 page per signal definition is so that we could have a namespace index page which would hopefully list everything in that namespace be it events, log records, metrics, spans etc. If we have 1 page it quickly grows out of hand and this approach is inline with the proposal to update the metric layout.
Yes can do
If possible I would get rid of the starts with altogether and just do filtering on the last mapping and is what is required for the general namespace page. |
@jsuereth Following on from the semconv meeting, I will do the following:
|
Progresses #2382
Changes
This introduces an event registry to reside alongside the attributes registry and the soon to be released entities registry. This provides pure code generated documentation for events which reduces maintenance effort and makes things more discoverable.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]