Fix skipped E2E tests and publish the test logs in artifact assembler #4450
+121
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: aishwaryabh <37918412+aishwaryabh@users.noreply.github.com>
Co-authored-by: aishwaryabh <37918412+aishwaryabh@users.noreply.github.com>
Co-authored-by: aishwaryabh <37918412+aishwaryabh@users.noreply.github.com>
Co-authored-by: aishwaryabh <37918412+aishwaryabh@users.noreply.github.com>
…tools into aibhandari/fix-skipped-tests
liliankasem
reviewed
May 30, 2025
liliankasem
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #4390
This PR fixes the skipped E2E tests and re-enables them back into CI. Some of the tests have different behavior compared the same tests running on inproc (ex: the invalid host json test fails in inproc but it succeeds in out-of-proc, so this PR accounts for the differences.
This PR also publishes the test logs to the artifact assembler so that the logs can be viewed in the pipeline run.
Pull request checklist