Skip to content

Add a timeout to ProcessStartedHandler #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aishwaryabh opened this issue Apr 24, 2025 · 0 comments
Open

Add a timeout to ProcessStartedHandler #4392

aishwaryabh opened this issue Apr 24, 2025 · 0 comments

Comments

@aishwaryabh
Copy link
Contributor

aishwaryabh commented Apr 24, 2025

After merging in this PR, when the tests are run locally today for core tools for func start, if the process starts up and is not interrupted within the test by the processStartedHandler (example: we expect the test to fail and throw an error before the host starts up, but it doesn't so the test is stuck since the host starts up successfully and is waiting for the user to manually kill the process), the test stalls, which is a flaw in the design.

To workaround this, a timeout would need to be added to the processTask here. If the timeout is reached before processStarted is finished, we have to manually kill the process by doing _process.Kill(true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant