-
Notifications
You must be signed in to change notification settings - Fork 453
Update the default pipeline to upload artifacts to internal feed for nightly builds and consolidated pipeline updates #4422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aishwaryabh
merged 15 commits into
main
from
aibhandari/consolidated-pipeline-default-updates
Jun 2, 2025
Merged
Update the default pipeline to upload artifacts to internal feed for nightly builds and consolidated pipeline updates #4422
aishwaryabh
merged 15 commits into
main
from
aibhandari/consolidated-pipeline-default-updates
Jun 2, 2025
+203
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Loading status checks…
liliankasem
reviewed
May 15, 2025
liliankasem
reviewed
May 15, 2025
Loading status checks…
liliankasem
reviewed
May 16, 2025
Loading status checks…
Loading status checks…
Loading status checks…
liliankasem
reviewed
May 21, 2025
740664f
to
6ed52de
Compare
Loading status checks…
424a288
to
bc4bd2a
Compare
liliankasem
approved these changes
May 29, 2025
kshyju
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Resolves #4420
I'm fixing the consolidated pipeline to automatically trigger when a build is done on either the core-tools.official pipeline or the core-tools-host pipeline. However we want to distinguish between nightly builds and regular builds that were triggered by CI. Therefore, we can separate the nightly build artifacts from the CI triggered artifacts by uploading the nightly build artifacts to an internal feed.
The format of the artifact version will be: YYYY.MMDD.buildId (where MM has no leading zeros).
Here is an example of the feed:
https://azfunc.visualstudio.com/internal/_artifacts/feed/core-tools-nightly-build
This PR also conditionally downloads the artifacts from the nightly build feed in the consolidated pipeline, if the consolidated pipeline run is also only a nightly build. Otherwise, we just take whatever was triggered by CI and use that build.
Note if the consolidated pipeline is manually run, we just use whatever is the latest run (regardless of nightly build or not).
The artifacts have also been updated to being with
func
when published, such asfunc-cli
Pull request checklist