Consolidate duplicate scripts within eng/scripts #4442
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates duplicate PowerShell scripts between
eng/scripts/
andeng/scripts/ArtifactAssemblerHelpers/
directories to eliminate code duplication while maintaining backward compatibility with existing pipelines.Changes Made
Consolidated Scripts
testArtifacts.ps1
- Root script now wraps the more advanced ArtifactAssemblerHelpers versiontestVsArtifacts.ps1
- Root script now wraps the more advanced ArtifactAssemblerHelpers versiongenerateSha.ps1
- Unified into a single script that handles both legacy and new pipeline scenariosgenerateMsiFiles.ps1
- Unified into a single script that handles both legacy and new pipeline scenariosKey Features
Testing
Validated that all operation modes work correctly:
Before/After Comparison
Before: Two separate implementations with overlapping functionality
After: Unified implementation with lightweight wrappers
The consolidation approach ensures both pipeline structures (
build-test.yml
andassemble-artifacts.yml
) continue to function correctly while sharing the same underlying implementation.Fixes #4369.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
azfunc.pkgs.visualstudio.com
/usr/bin/dotnet build .\test\Cli\Func.E2E.Tests\Azure.Functions.Cli.E2E.Tests.csproj
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.