Remove LinuxImageDemand variable and replace usage with actual string value #41734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
weshaggard
June 24, 2025 00:19
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unnecessary LinuxImageDemand variable definition from the pipeline configuration and replaces its usage with the explicit string value "ImageOverride -equals ubuntu-24.04" to improve clarity and consistency.
- Removed the LinuxImageDemand variable from eng/pipelines/templates/variables/image.yml
- Inlined the demand string in eng/pipelines/docindex.yml to remove indirection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/templates/variables/image.yml | Removed the LinuxImageDemand variable definition |
| eng/pipelines/docindex.yml | Replaced the variable reference with a hardcoded value |
weshaggard
reviewed
Jun 24, 2025
Copilot finished work on behalf of
weshaggard
June 24, 2025 00:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
LinuxImageDemandvariable from theimage.ymlfile and replaces its usage with the actual string value, aligning with the changes made in Azure/azure-sdk-for-net#50802.Changes Made
1. Removed Variable Definition
File:
eng/pipelines/templates/variables/image.ymlLinuxImageDemandvariable definition:2. Replaced Variable Usage
File:
eng/pipelines/docindex.ymlRationale
Verification
LinuxImageDemandorWindowsImageDemandin the repositoryubuntu-24.04) matches the currentLINUXVMIMAGEvariable valueNote:
WindowsImageDemandwas not found in this repository, suggesting it was either already removed or never existed in the Python SDK.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.