Skip to content

[Storage] [Named Keywords] [File Share] _file_client.py and aio, context managers #41751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weirongw23-msft
Copy link
Member

No description provided.

@weirongw23-msft weirongw23-msft marked this pull request as ready for review June 24, 2025 22:36
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jun 24, 2025
Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just need to sweep for unused + hanging Q about why seemingly only 1 file we unrolled the typing imports.

@weirongw23-msft weirongw23-msft merged commit c817ff5 into Azure:feature/storage-fs-pyi Jun 25, 2025
19 checks passed
@weirongw23-msft weirongw23-msft deleted the weirongw23/file-client-pyi branch June 25, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants