[AutoRelease] t2-netapp-2025-06-25-94863(can only be merged by SDK owner) #41753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API version and related metadata across the NetApp management SDK and its generated test and sample files in preparation for the GA release. Key changes include updating API version strings from "2025-01-01-preview" to "2025-03-01", marking the package as stable, and adjusting sample file data (for example, updating a subscription ID in a subnetId string).
Reviewed Changes
Copilot reviewed 200 out of 200 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/netapp/azure-mgmt-netapp/sdk_packaging.toml | Sets “is_stable” to true for the release. |
| generated_tests/* | Updates API version parameters in test methods from preview to stable. |
| generated_samples/* | Updates x-ms-original-file paths (and in one case, a subnetId value) from the preview version to the stable release version. |
Comments suppressed due to low confidence (3)
sdk/netapp/azure-mgmt-netapp/sdk_packaging.toml:5
- Marking the package as stable is appropriate for the GA release. Please ensure that all related documentation and pipelines are updated accordingly.
is_stable = true
sdk/netapp/azure-mgmt-netapp/generated_tests/test_net_app_management_volumes_operations_async.py:29
- The API version update to '2025-03-01' is consistent with the stable release. Verify that all service client methods and related tests are compatible with the new version.
api_version="2025-03-01",
sdk/netapp/azure-mgmt-netapp/generated_samples/volumes_create_or_update.py:44
- The subnetId now uses a different subscription ID. Please confirm that this update is intentional and aligns with the intended deployment environment.
"subnetId": "/subscriptions/9760acf5-4638-11e7-9bdb-020073ca7778/resourceGroups/myRP/providers/Microsoft.Network/virtualNetworks/testvnet3/subnets/testsubnet3",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6356
Recording test fail, detailed info is in pipeline log(search keyword FAILED)!!!
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1015