Log error for 401/403 to assist with customer troubleshooting #41767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
requested review from
jeremydvoss,
hectorhdzg,
rads-1996,
Karlie-777,
MSNev and
JacksonWeber
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error visibility by logging 401/403 responses for customer troubleshooting, streamlines retrieval of the Application Insights authentication string, and updates the changelog to document the new logging.
- Added specific error logs for 401 (Unauthorized) and 403 (Forbidden) in
_transmit - Moved
os.getenvcall outside the conditional in_get_authentication_credentialto consolidate variable assignment - Updated CHANGELOG to reflect the new logging behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| azure/monitor/opentelemetry/exporter/export/_base.py | Log specific messages on 401/403, adjust environment variable usage for authentication string |
| CHANGELOG.md | Document the addition of 401/403 logging for troubleshooting |
Comments suppressed due to low confidence (1)
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py:250
- Consider adding unit tests to cover the new logging branches for 401 and 403 status codes, ensuring these log messages are triggered as expected.
# Log error for 401: Unauthorized, 403: Forbidden to assist with customer troubleshooting
...or/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py
Show resolved
Hide resolved
...or/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py
Show resolved
Hide resolved
rads-1996
reviewed
Jun 25, 2025
|
Are there any tests for this change? |
JacksonWeber
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.