Skip to content

[AVM Module Issue]: Missing Diagnostic Settings for Container-Instance #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
RyansGitrepos opened this issue Oct 12, 2024 · 8 comments · May be fixed by #4929
Open
1 task done

[AVM Module Issue]: Missing Diagnostic Settings for Container-Instance #3519

RyansGitrepos opened this issue Oct 12, 2024 · 8 comments · May be fixed by #4929
Assignees
@JPEasier
Labels
Class: Resource Module 📦 This is a resource module Status: Looking For Assistance 🦆 This item is looking for anyone to help develop the code and submit a PR for resolution Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@RyansGitrepos
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/container-instance/container-group

(Optional) Module Version

0.2.0

Description

Hi Team,

Can we add Diagnostics to the AVM module for Container Instances?
Currently missing this feature in the module: "br/public:avm/res/container-instance/container-group:0.2.0"

As described on:
https://learn.microsoft.com/en-us/azure/templates/microsoft.containerinstance/containergroups?pivots=deployment-language-bicep

    diagnostics: {
      logAnalytics: {
        logType: 'string'
        metadata: {}
        workspaceId: 'string'
        workspaceKey: 'string'
        workspaceResourceId: 'string'
      }
    }

(Optional) Correlation Id

No response
@RyansGitrepos RyansGitrepos added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 12, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Oct 12, 2024
@avm-team-linter AVM Team Linter
Copy link

@RyansGitrepos, thanks for submitting this issue for the avm/res/container-instance/container-group module!

Important

A member of the @Azure/avm-res-containerinstance-containergroup-module-owners-bicep or @Azure/avm-res-containerinstance-containergroup-module-contributors-bicep team will review it soon!

@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Oct 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed labels Oct 17, 2024
@AlexanderSehr
Copy link
Contributor

Hey @JPEasier,
please take a look when you get the chance. With the common type + other example implementations, this should be a breeze 😉

@JPEasier
Copy link
Contributor

Hi @RyansGitrepos,
thanks for the idea. yep we can we can definitely do that.

@JPEasier JPEasier added Status: Looking For Assistance 🦆 This item is looking for anyone to help develop the code and submit a PR for resolution and removed Needs: Triage 🔍 Maintainers need to triage still Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Dec 12, 2024
@SanderNugteren
Copy link

Hi! I need this functionality, so I would be willing to make a pull request. I see that is possible here: https://azure.github.io/Azure-Verified-Modules/resources/faq/#are-there-different-ways-to-contribute-to-avm

Is there anything else that I need to know/would be handy to know? In particular, is there a way to test my changes locally?

@SanderNugteren
Copy link

@AlexanderSehr I think I have the PR ready. However, I can't create a branch in this project. Should someone grant me this permission? Or am I missing something else? I am working from my company laptop, so perhaps there is something else going one with certificates or something, but I get the following:

git push --set-upstream origin users/SanderNugteren/containerInstanceDiagnostic
warning: ----------------- SECURITY WARNING ----------------
warning: | TLS certificate verification has been disabled! |
warning: ---------------------------------------------------
warning: HTTPS connections may not be secure. See https://aka.ms/gcm/tlsverify for more information.
info: please complete authentication in your browser...
warning: ----------------- SECURITY WARNING ----------------
warning: | TLS certificate verification has been disabled! |
warning: ---------------------------------------------------
warning: HTTPS connections may not be secure. See https://aka.ms/gcm/tlsverify for more information.
remote: Permission to Azure/bicep-registry-modules.git denied to SanderNugteren.
fatal: unable to access 'https://github.com/Azure/bicep-registry-modules.git/': The requested URL returned error: 403

@AlexanderSehr
Copy link
Contributor

Hey @SanderNugteren,
as is custom for open-source projects it's not possible to create branches in the upstream repository unless being part of the repo's maintainers. Instead, contributions are implemented in forks where they are implemented and validated from where a Pull Request back to upstream is then initiated to get the changes in :)
We documented guidance around this flow here.

@SanderNugteren
Copy link

Ah, I see! Haven't really contributed to open source before. Will give the link a read tomorrow and continue. Thanks for getting back to me!

@AlexanderSehr
Copy link
Contributor

Ah, I see! Haven't really contributed to open source before. Will give the link a read tomorrow and continue. Thanks for getting back to me!

Anytime. It may seem a bit daunting at first (setting the CI up), but if you break it down it's only a handful of steps and a one time action.
Just don't forget to run the .Platform - Toggle AVM workflows workflow once setting up the fork. You don't want to run all workflows in your fork like in upstream AVM, trust me 😉

@SanderNugteren SanderNugteren linked a pull request Mar 28, 2025 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JPEasier JPEasier

Labels
Class: Resource Module 📦 This is a resource module Status: Looking For Assistance 🦆 This item is looking for anyone to help develop the code and submit a PR for resolution Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
AVM - Module Issues
Status: Needs: Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add diagnostics parameter SanderNugteren/bicep-registry-modules
4 participants
@SanderNugteren @AlexanderSehr @JPEasier @RyansGitrepos