feat: Update avm/res/container-instance/container-group README.md
#4774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eLabelScope parameter details
…ameter to include required condition for DnsNameLabel
avm-team-linter
bot
added
the
Needs: Core Team 🧞
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
JPEasier
changed the title
avm/res/container-instance/container-group README.md
JPEasier
changed the title
avm/res/container-instance/container-group README.mdavm/res/container-instance/container-group README.md
…dnsNameLabel presence
jikuja
reviewed
Mar 20, 2025
| @@ -34,7 +34,7 @@ param imageRegistryCredentials imageRegistryCredentialType[]? | |||
| @description('Optional. Location for all Resources.') | |||
| param location string = resourceGroup().location | |||
|
|
|||
| @description('Optional. Specify level of protection of the domain name label.') | |||
| @description('Conditional. The value representing the security enum. The \'Unsecure\' value is the default value if not selected and means the object\'s domain name label is not secured against subdomain takeover. The \'TenantReuse\' value is the default value if selected and means the object\'s domain name label can be reused within the same tenant. The \'SubscriptionReuse\' value means the object\'s domain name label can be reused within the same subscription. The \'ResourceGroupReuse\' value means the object\'s domain name label can be reused within the same resource group. The \'NoReuse\' value means the object\'s domain name label cannot be reused within the same resource group, subscription, or tenant. Required if `DnsNameLabel` is set.') | |||
There was a problem hiding this comment.
Suggestion:
Condition for this and for dnsNameLabel should probably be "Required if ipAddressType is Public"
There was a problem hiding this comment.
Addressed. @JPEasier, please note a couple conflict sneaked in
…nsNameLabel parameters to clarify required conditions
AlexanderSehr
approved these changes
May 12, 2025
|
This PR is obsolet with the latest module version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
autoGeneratedDomainNameLabelScopeautoGeneratedDomainNameLabelScopeCloses #3501
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.