-
Notifications
You must be signed in to change notification settings - Fork 450
feat: add gh issue label logic #4863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
name: .Platform - Set GitHub issue label | ||
|
||
on: | ||
schedule: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the logic is the same I'd suggest a single platform pipeline, running on schedule as well as on issue creation (issues types [opened])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eriqua it is the same logic, but the issue creation one only looks into one issue (the new one), while the scheduled one looks at all open issues, so there is a loop into it, that calls the other logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion would be to merge the 2 and use github.event_name
to check which event triggered the workflow. Based on that call the corresponding intended logic.
However, given another PR #4987 was opened meanwhile and updating some of the common logic, I'd suggest to have this PR in to allow the review of the other one. Then, think about the optimization later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the logic tested locally? I'd suggest the following test coverage:
- create a test issue on an owned module, run the logic and verify the owner is assigned
- assign the orphaned label on the owned test issue, run the logic and verify the label is removed
- create a test issue on an orphaned module, run the logic and verify the orphaned label is assigned
- assign an owner to the orphaned test issue, run the logic and verify the owner is unassigned
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Description
For all open AVM issue, assignment of the module owner or orphaned label assignment is checked and corrected.
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.