feat: Web-Site - Merge config variants #5083
Open
+30,859
−5,405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
AlexanderSehr
added
Class: Resource Module 📦
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
AlexanderSehr
temporarily deployed
to
avm-validation
GitHub Actions
Inactive
AlexanderSehr
temporarily deployed
to
avm-validation
GitHub Actions
Inactive
AlexanderSehr
temporarily deployed
to
avm-validation
GitHub Actions
Inactive
AlexanderSehr
temporarily deployed
to
avm-validation
GitHub Actions
Inactive
AlexanderSehr
had a problem deploying
to
avm-validation
GitHub Actions
Failure
avm-team-linter
bot
added
the
Needs: Core Team 🧞
AlexanderSehr
commented
May 5, 2025
| name: slotName | ||
| } | ||
| } | ||
| resource msdeploy 'Microsoft.Web/sites/slots/extensions@2024-04-01' = { |
There was a problem hiding this comment.
Hey @tsc-buddy & @pankajagrawal16,
this is the interesting case where the original resource type was
Even though this module is a child of the slot child-module. Hence the update to Microsoft.Web/sites/slots/extensions. Let me know what you think and if this was on purpose.
For the other folders it seems correct.
There was a problem hiding this comment.
Good Find. @tsc-buddy Any insights on this? This cannot be intentional ?
AlexanderSehr
added a commit
that referenced
this pull request
May 5, 2025
…5147) ## Description The function may now return `Diagnostic` information that is considere a warning. However, because the current implementation treats **any** return value as an error, these warnings are blocking. The updated implementation differentiates the two by only throwing an error if the return value contains a `code`. This PR is a dependency for #5083 as that PR does return diagnostic warnings (false positives) and cannot get past the `Test-AzDeployment` stage without the fix ### Example output ```pwsh PS C:\dev> $res = Test-AzSubscriptionDeployment @DeploymentInputs -Location $DeploymentMetadataLocation # Using Bicep v0.35.1 # Calling Bicep with arguments: build "C:\dev\avm\res\web\site\tests\e2e\webAppLinux.max\main.test.bicep" --stdout # C:\dev\avm\res\web\site\main.bicep(545,25) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: secure value 'slots[*].siteConfig.azureStorageAccounts.*.accessKey' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] # 14:16:04 - Template is valid. # Diagnostics (2): # (/subscriptions/<subId>/resourceGroups/dep-avmx-web.sites-wswalmax-rg/providers/Microsoft.Resources/deployments/x5ei2emr6nll2-test-wswalmax-init) A nested deployment got short-circuited and all its resources got skipped from validation. This is due to a nested template having a parameter that was not fully evaluated (e.g. contains a reference() function). Please see https://aka.ms/WhatIfEvalStopped for more guidance. (NestedDeploymentShortCircuited) # (/subscriptions/<subId>resourceGroups/dep-avmx-web.sites-wswalmax-rg/providers/Microsoft.Resources/deployments/x5ei2emr6nll2-test-wswalmax-idem) A nested deployment got short-circuited and all its resources got skipped from validation. This is due to a nested template having a parameter that was not fully evaluated (e.g. contains a reference() function). Please see https://aka.ms/WhatIfEvalStopped for more guidance. (NestedDeploymentShortCircuited) $res # Diagnostics (2): # (/subscriptions/<subId>/resourceGroups/dep-avmx-web.sites-wswalmax-rg/providers/Microsoft.Resources/deployments/x5ei2emr6nll2-test-wswalmax-init) A nested deployment got short-circuited and all its resources got skipped from validation. This is due to a nested template having a parameter that was not fully evaluated (e.g. contains a reference() function). Please see https://aka.ms/WhatIfEvalStopped for more guidance. (NestedDeploymentShortCircuited) # (/subscriptions/<subId>resourceGroups/dep-avmx-web.sites-wswalmax-rg/providers/Microsoft.Resources/deployments/x5ei2emr6nll2-test-wswalmax-idem) A nested deployment got short-circuited and all its resources got skipped from validation. This is due to a nested template having a parameter that was not fully evaluated (e.g. contains a reference() function). Please see https://aka.ms/WhatIfEvalStopped for more guidance. (NestedDeploymentShortCircuited) ``` ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [x] Update to CI Environment or utilities (Non-module affecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation
AlexanderSehr
added
Needs: Module Owner 📣
3 tasks
](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml){kind=link}
Co-authored-by: Pankaj Agrawal <pnkaj.agrwal@gmail.com>
This was referenced May 13, 2025
pankajagrawal16
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dnsConfigurationCloses #4252
Closes #4385
Pipeline Reference
Type of Change
version.json:version.json.version.json.Example Slot App Settings (Config):
Example Auth Settings (Config)
Example Log Settings (Config)
Example API Settings (Config)
