Skip to content

issues Search Results · repo:LoopringSecondary/protocol language:TypeScript

Filter by

65 results
 (74 ms)

65 results

inLoopringSecondary/protocol (press backspace or delete to remove)

LoopringSecondary/protocol
Settle multiple rings in a single transaction

I changed submitRing to take a single bytes array in PR #350 which makes it pretty easy to send data for multiple rings to submitRing. I was planning to test this out, but I m not completely sure if this ...
  • Brechtpd
  • Opened 
    on May 21, 2018
  • #351

LoopringSecondary/protocol
add a parameter in submitRing function to control the minial amount the ring will be settled.

  • kongliangzhong
  • 1
  • Opened 
    on Apr 28, 2018
  • #337

LoopringSecondary/protocol
Missing test cases

We need to test when any order s fillAmountS is 0, the ring will fail.
  • dong77
  • 1
  • Opened 
    on Apr 28, 2018
  • #335

LoopringSecondary/protocol
npm docker run failed

Now npm docker run not work, this is caused by npm s version upgradation. See https://github.com/zkat/pacote/issues/142, https://github.com/npm/npm/issues/19989 I will keep tracing on this.
  • kongliangzhong
  • Opened 
    on Apr 24, 2018
  • #332

LoopringSecondary/protocol
Optimization: batch update cancelledOrFilled amount

Inside the loop in the settleRing method, this function is called multiple times, // Update fill records if (state.buyNoMoreThanAmountB) { delegate.addCancelledOrFilled(state.orderHash, ...
  • dong77
  • 3
  • Opened 
    on Apr 23, 2018
  • #323

LoopringSecondary/protocol
Tests Not working

While i was making some gas optimizations, realized that the latest code doesnt have all the test cases working. Is there some other branch i should work on?
  • akash2504
  • 3
  • Opened 
    on Apr 22, 2018
  • #322

LoopringSecondary/protocol
Potential bug: RingMined emitting the same ring hash across multiple orders.

While i was working on a prototype. I was looking at the events emitted by the current deployed contract and I noticed that orders are outputting the same ringhash across different orders. For example ...
  • Hephyrius
  • 6
  • Opened 
    on Apr 21, 2018
  • #312

LoopringSecondary/protocol
Optimization by simplifying NameRegistry and removing miner signatures

We can relax the requirement that a miner needs to sign the ring as the ring will be signed with all the auth_key of the orders, then we can simplify NameRegistry to keep only the recipient address in ...
  • dong77
  • 1
  • Opened 
    on Apr 17, 2018
  • #302

LoopringSecondary/protocol
Reentry attack possible after pull request #289

ringIndex is updated with ENTERED_MASK in MEMORY, not in STORAGE. So ENTERED_MASK isn t set when loading ringIndex in a reentry scenario. This is a major security issue. This was introduced in pull request ...
  • Brechtpd
  • 7
  • Opened 
    on Apr 13, 2018
  • #290

LoopringSecondary/protocol
ERC20Token constructor should check input parameters

It should check: 1) token symbol contains only uppercase A to Z and . . . can occur at most once in the middle. The token symbol shall be less than 10 chars. 2) token name contains only A-Za-z_- ...
  • dong77
  • 5
  • Opened 
    on Apr 7, 2018
  • #281
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue search results · GitHub