Allow add labels to gha-runner-scale-set

[janpapaj1]

What would you like added?

Currently helm chart values do not support labels for k8s runners only runnerScaleSetName is allowed.

I would like to able label assign labels to self hosted runners in k8s like is this possible with self hosted runners (ec2 or windows) running.

Why is this needed?

To be able run dependabot jobs in k8s runners which has access to internal private registries which are not accessible over internet.

Additional context

As you can see listener has label but runner doesn't
Somthing like this in values.

runnerScaleSetLabels:

[github-actions]

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

[avelizmu]

Hello,

According to the discussions, the runner scale sets will not be supporting additional labels.
For creating a scale set to run dependabot, you can set the runner scale set name to dependabot

#2921 (reply in thread)

[janpapaj1]

Hi I tried this and wasn't able to run dependabot in self-hosted runners. Any advice here ? Thanks, Jan From: Adrian Veliz ***@***.***> Sent: Wednesday, March 6, 2024 8:20 PM To: actions/actions-runner-controller ***@***.***> Cc: Papaj, Jan (Cirium-SOU) ***@***.***>; Author ***@***.***> Subject: Re: [actions/actions-runner-controller] Allow add labels to gha-runner-scale-set (Issue #3327) *** External email: use caution *** Hello, According to the discussions, the runner scale sets will not be supporting additional labels. For creating a scale set to run dependabot, you can set the runner scale set name to dependabot #2921 (reply in thread)<#2921 (reply in thread)> - Reply to this email directly, view it on GitHub<#3327 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDT6P4XZCDKV2G7VME7DB73YW53ABAVCNFSM6AAAAABEI3R4EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBRG4YTGOBTGU>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

…

________________________________ The information contained in this e-mail message is intended only for the personal and confidential use of the recipient(s) named above. This message may be an attorney-client communication and/or work product and as such is privileged and confidential. If the reader of this message is not the intended recipient or an agent responsible for delivering it to the intended recipient, you are hereby notified that you have received this document in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify us immediately by e-mail, and delete the original message.

[AlexandreODelisle]

Running Dependabot via the GHEC (GitHub Entreprise Cloud) is not yet supported.

There is currently this following Issue in the Roadmap that may be of interest for you, github/roadmap#929.

[ohookins]

Labels on the runner scale sets outside of the specific Dependabot use case would still be useful. For example, to allow for having multiple redundant pools of runners (multi-cluster scenario) with identical capabilities, and to be able to elegantly select self-hosted runner capacities without having to hard-code runner set names.

[anthony-yeong-partior]

+1 vote

[gabriel-suela]

+1 vote

[HenrikDK]

How is this still an issue? Dependabot for GHEC has already shipped but this glaring gap still remains?

If Github intends to remain firm on the "single label" for scale-set runners choice then maybe an option in the helm chart to enable "dependabot" and "code-scanning" on a runner?, or go back to those two teams and have them rework their solutions to conform to the limitations of the scaleset project?

[kuhnroyal]

I deployed a second scale set named dependabot - was pretty easy in the end.

But I agree that there should be a way to add labels.