-
Notifications
You must be signed in to change notification settings - Fork 1.2k
JOBREPOSITORY does not respect repo name changes #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello! Thank you for filing an issue. The maintainers will triage your issue shortly. In the meantime, please take a look at the troubleshooting guide for bug reports. If this is a feature request, please review our contribution guidelines. |
Is there any progress on this? |
My team is also experiencing this issue with the latest |
As a workaround, one might consider using the REST API to fetch the repository in question, follow the redirect, and get the real name. This would require a GitHub app with a token, though. |
@Link- , @nikola-jokic, are there any updates on this issue? I saw there were some great metrics changes included in the It would be great to get this issue resolved as well since it prevents accurate metric collecting. |
@ajschmidt8 - it's on our radar but we haven't been able to prioritise the work on this yet. |
Checks
Controller Version
0.9.0
Deployment Method
ArgoCD
Checks
To Reproduce
multi-service
platform-core-services
kubectl get ephemeralrunners
JOBREPOSITORY
is using the original repository name instead of the new name.Describe the bug
I noticed when looking at what jobs were actively running on our runners with
kubectl get ephemeralrunners
that there were repo names that I didn't recognize in theJOBREPOSITORY
field. Upon further inspection it is because this field is using an original name of the repository instead of the current name of the repository. For a specific example we have a repository in our org calledplatform-core-services
. The original repo name wasmulti-service
, and this is what is being reported:If I navigate to github.com/ORG/multi-service it properly redirects to github.com/ORG/platform-core-services, but looking at this output and
JOBREPOSITORY
is a bit weird.Describe the expected behavior
I would expect that the
JOBREPOSITORY
field onephemeralrunners
shows the current name of a repository and not the original name.Additional Context
I'm happy to provide any values.yaml or logs if needed but there isn't anything in logs or our configuration that seems to show the issue or define this setting. Looking at the output of
kubectl get ephemeralrunners
is where the issue presents itself.N/A
Controller Logs
Runner Pod Logs
The text was updated successfully, but these errors were encountered: