Skip to content

Fix typos #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ RUN go mod download
# Usage:
# docker buildx build --tag repo/img:tag -f ./Dockerfile . --platform linux/amd64,linux/arm64,linux/arm/v7
#
# With the above commmand,
# With the above command,
# TARGETOS can be "linux", TARGETARCH can be "amd64", "arm64", and "arm", TARGETVARIANT can be "v7".

ARG TARGETPLATFORM TARGETOS TARGETARCH TARGETVARIANT VERSION=dev COMMIT_SHA=dev

# We intentionally avoid `--mount=type=cache,mode=0777,target=/go/pkg/mod` in the `go mod download` and the `go build` runs
# to avoid https://github.com/moby/buildkit/issues/2334
# We can use docker layer cache so the build is fast enogh anyway
# We can use docker layer cache so the build is fast enough anyway
# We also use per-platform GOCACHE for the same reason.
ENV GOCACHE /build/${TARGETPLATFORM}/root/.cache/go-build

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ type RunnerReplicaSetStatus struct {
// +optional
Replicas *int `json:"replicas"`

// ReadyReplicas is the number of runners that are created and Runnning.
// ReadyReplicas is the number of runners that are created and Running.
ReadyReplicas *int `json:"readyReplicas"`

// AvailableReplicas is the number of runners that are created and Runnning.
// This is currently same as ReadyReplicas but perserved for future use.
// AvailableReplicas is the number of runners that are created and Running.
// This is currently same as ReadyReplicas but preserved for future use.
AvailableReplicas *int `json:"availableReplicas"`
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.14.0
controller-gen.kubebuilder.io/version: v0.18.0
name: horizontalrunnerautoscalers.actions.summerwind.dev
spec:
group: actions.summerwind.dev
Expand Down Expand Up @@ -159,10 +159,8 @@ spec:
ScaleUpTriggers is an experimental feature to increase the desired replicas by 1
on each webhook requested received by the webhookBasedAutoscaler.


This feature requires you to also enable and deploy the webhookBasedAutoscaler onto your cluster.


Note that the added runners remain until the next sync period at least,
and they may or may not be used by GitHub Actions depending on the timing.
They are intended to be used to gain "resource slack" immediately after you
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion cmd/ghalistener/worker/worker.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ func (w *Worker) HandleDesiredRunnerCount(ctx context.Context, count, jobsComple
return w.lastPatch, nil
}

// calculateDesiredState calculates the desired state of the worker based on the desired count and the the number of jobs completed.
// calculateDesiredState calculates the desired state of the worker based on the desired count and the number of jobs completed.
func (w *Worker) setDesiredWorkerState(count, jobsCompleted int) int {
// Max runners should always be set by the resource builder either to the configured value,
// or the maximum int32 (resourcebuilder.newAutoScalingListener()).
Expand Down
90 changes: 10 additions & 80 deletions config/crd/bases/actions.github.com_autoscalinglisteners.yaml

Large diffs are not rendered by default.

175 changes: 19 additions & 156 deletions config/crd/bases/actions.github.com_autoscalingrunnersets.yaml

Large diffs are not rendered by default.

96 changes: 15 additions & 81 deletions config/crd/bases/actions.github.com_ephemeralrunners.yaml

Large diffs are not rendered by default.

94 changes: 15 additions & 79 deletions config/crd/bases/actions.github.com_ephemeralrunnersets.yaml

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.14.0
controller-gen.kubebuilder.io/version: v0.18.0
name: horizontalrunnerautoscalers.actions.summerwind.dev
spec:
group: actions.summerwind.dev
Expand Down Expand Up @@ -159,10 +159,8 @@ spec:
ScaleUpTriggers is an experimental feature to increase the desired replicas by 1
on each webhook requested received by the webhookBasedAutoscaler.


This feature requires you to also enable and deploy the webhookBasedAutoscaler onto your cluster.


Note that the added runners remain until the next sync period at least,
and they may or may not be used by GitHub Actions depending on the timing.
They are intended to be used to gain "resource slack" immediately after you
Expand Down
105 changes: 13 additions & 92 deletions config/crd/bases/actions.summerwind.dev_runnerdeployments.yaml

Large diffs are not rendered by default.

111 changes: 16 additions & 95 deletions config/crd/bases/actions.summerwind.dev_runnerreplicasets.yaml

Large diffs are not rendered by default.

105 changes: 13 additions & 92 deletions config/crd/bases/actions.summerwind.dev_runners.yaml

Large diffs are not rendered by default.

98 changes: 12 additions & 86 deletions config/crd/bases/actions.summerwind.dev_runnersets.yaml

Large diffs are not rendered by default.

Loading