Skip to content

go-build directory should still be cached if a cache hit occured. #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kminehart opened this issue Mar 11, 2025 · 1 comment
Open
Labels
feature request New feature or request to improve the current logic

Comments

@kminehart
Copy link

kminehart commented Mar 11, 2025

Description:
the Go build cache, among many things, stores the test cache. I propose that, even in the event of a cache hit, we save the go-build directory so that the new test results and build cache can be saved.

Justification:
If the test cache does not get saved, then over a short period time, the cache that is saved will not be applicable. Saving the build cache even when there was a cache hit will result in less repeat test runs.

This could result in a much larger cache being stored. Maybe this should require a flag, like cache-on-failure?

Are you willing to submit a PR?

Yes!

@kminehart kminehart added feature request New feature or request to improve the current logic needs triage labels Mar 11, 2025
@mahabaleshwars
Copy link

Hi @kminehart,
Thank you for creating this feature request. We will investigate it and provide feedback as soon as we have some updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants