Skip to content

Most AdoptOpenJDK references and API calls should swap to Adoptium #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
karianna opened this issue Nov 27, 2022 · 5 comments
Open

Most AdoptOpenJDK references and API calls should swap to Adoptium #415

karianna opened this issue Nov 27, 2022 · 5 comments
Assignees
@dmitry-shibanov
Labels
feature request New feature or request to improve the current logic

Comments

@karianna
Copy link

As per the Blog Post in 2021 - AdoptOpenJDK has migrated to the Eclipse Foundation and serves binaries through adoptium.net.

NOTE: This is not a straight simple swap as some legacy/old Java binaries are only made available through the old AdoptOpenJDK API which setup-java may still wish to support.
@karianna karianna added feature request New feature or request to improve the current logic needs triage labels Nov 27, 2022
@panticmilos
Copy link
Contributor

hi @karianna, thank you for your report. We will take a look at it.

@dmitry-shibanov dmitry-shibanov self-assigned this Dec 1, 2022
@panticmilos panticmilos self-assigned this Dec 5, 2022
@joschi
Copy link
Contributor

joschi commented Dec 6, 2022

@karianna Eclipse Temurin (via Adoptium API) is supported already (see #201).

What would replacing the AdoptOpenJDK API with the Adoptium API in the adopt provider improve specifically?

https://github.com/actions/setup-java#supported-distributions also already mentions that AdoptOpenJDK is deprecated and has been replaced by Eclipse Temurin.

@karianna
Copy link
Author

karianna commented Dec 7, 2022

Pulling @johnoliver in - he runs our API and noticed that requests were seemingly coming to the wrong domain from the action.

@panticmilos
Copy link
Contributor

hi @karianna and @johnoliver, just a gentle ping, I would like to hear your additional opinions about this topic.

@panticmilos
Copy link
Contributor

hey @karianna and @johnoliver, just a gentle ping :)

@IvanZosimov IvanZosimov self-assigned this Feb 10, 2023
@panticmilos panticmilos removed their assignment Feb 13, 2023
@IvanZosimov IvanZosimov removed their assignment Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-shibanov dmitry-shibanov

Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joschi @karianna @dmitry-shibanov @IvanZosimov @panticmilos