Skip to content

Commit 5aa72c2

Browse files
Apply suggestions from code review
Co-authored-by: Alena Sviridenko <alenasviridenko@github.com>
1 parent d9aab2a commit 5aa72c2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

docs/adrs/0001-support-caching-deps-for-monorepos.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Currently, `actions/setup-node` supports caching dependencies for Npm and Yarn p
88
For the first iteration, we have decided to not support cases where `package-lock.json` / `yarn.lock` are located outside of repository root.
99
Current implementation searches the following file patterns in the repository root: `package-lock.json`, `yarn.lock` (in order of resolving priorities)
1010

11-
Obviosly, it made build-in caching unusable for mono-repos and repos with complex structure.
11+
Obviously, it made build-in caching unusable for mono-repos and repos with complex structure.
1212
We would like to revisit this decision and add customization for dependencies lock file location.
1313

1414
## Proposal
@@ -24,8 +24,8 @@ The second option looks more generic because it allows to:
2424
## Decision
2525

2626
Add `deps-lock-file` input that will accept path (relative to repository root) to dependencies lock file.
27-
If path provided path contains wildcards, the action will search all maching files and calculate common hash like `${{ hashFiles('**/packages.lock.json') }}` YAML construction does.
28-
The hash of privided matched files will be used as a part of cache key.
27+
If provided path contains wildcards, the action will search all maching files and calculate common hash like `${{ hashFiles('**/packages.lock.json') }}` YAML construction does.
28+
The hash of provided matched files will be used as a part of cache key.
2929

3030
Yaml examples:
3131
```yml
@@ -45,4 +45,4 @@ steps:
4545
node-version: 14
4646
cache: yarn
4747
deps-lock-file: 'sub-project/**/yarn.lock'
48-
```
48+
```

0 commit comments

Comments
 (0)