Skip to content

Consider including architecture in cache keys #1008

Closed
@silverwind

Description

@silverwind

Description:
The cache keys are currently node-cache-Linux-npm-<hash> which does not seem to include the CPU architecture so if npm dependencies include native binaries and the same cache is restored on a different architecture than what it was built on, these binaries would fail to run.

Action version:
4

Platform:
All

Runner type:
All

Tools version:
All

Repro steps:

  • Build a cache on a x86 runner
  • Restore cache on a ARM runner

Expected behavior:
Cache key should include architecture

Actual behavior:
Cache key does not include architecture

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestNew feature or request to improve the current logic

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions