Skip to content

Support systems without preexisting nodejs #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 of 5 tasks
a-b opened this issue Apr 24, 2025 · 12 comments
Open
3 of 5 tasks

Support systems without preexisting nodejs #1287

a-b opened this issue Apr 24, 2025 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@a-b
Copy link

a-b commented Apr 24, 2025

Description:
This action is not working if there is no preexisting node on the system

Action version:
v4

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
Run workflow on the runner without nodejs.

Expected behavior:
Action won't depend on the existing nodejs to install one on the system

Actual behavior:
Getting an error that there is no nodejs.

@a-b a-b added bug Something isn't working needs triage labels Apr 24, 2025
@aparnajyothi-y aparnajyothi-y self-assigned this Apr 25, 2025
@aparnajyothi-y
Copy link
Contributor

Hello @a-b, Thank you for creating this issue and we will look into it :)

@aparnajyothi-y aparnajyothi-y removed their assignment Apr 25, 2025
@lmvysakh lmvysakh self-assigned this Apr 25, 2025
@mahabaleshwars
Copy link

Hi @a-b,
I am closing this issue as it seems like spam.

@a-b
Copy link
Author

a-b commented Apr 25, 2025

Can you explain what is unreasonable about rewriting it as a shell script to eliminate the dependency on Node? This would allow the installation and configuration of the specified version of Node on a greenfield system.

@a-b
Copy link
Author

a-b commented Apr 25, 2025

@mahabaleshwars please elaborate on what motivated you to consider my request as a spam.

@mahabaleshwars
Copy link

Hi @a-b,
Apologies for the earlier mistake in closing this. I will reopen it for further attention.

@pablopicasso111
Copy link

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 14, 16, 18 ]
name: Node ${{ matrix.node }} sample
steps:
- uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- run: npm ci
- run: npm test

@lmvysakh
Copy link

lmvysakh commented May 2, 2025

Hi @a-b,

Thank you for bringing this issue to our attention.

To help us investigate and assist you more effectively, could you please elaborate on the problem you're encountering? Specifically, it would be helpful if you could provide additional details regarding your setup and expectations. Additionally, we kindly request that you share relevant workflow runs or logs that demonstrate the issue.

These details will allow us to better understand your scenario and identify a suitable resolution.

Looking forward to your response!

@lmvysakh
Copy link

lmvysakh commented May 9, 2025

Hello @a-b,

Just a gentle reminder! Could you please let us know if there are any updates from your side regarding this issue?

@a-b
Copy link
Author

a-b commented May 10, 2025

The issue persists; I cannot run this action without Node.

@lmvysakh
Copy link

Hi @a-b,

Thank you for your response. To help us investigate this issue further, we kindly request you to provide the following details:

  • A detailed explanation of the issue you're facing and your expectations regarding the action's behavior.
  • Workflow files or relevant workflow runs that demonstrate the issue.

These additional details will allow us to better understand your scenario and identify a resolution. Without this information, it will be challenging for us to proceed with the investigation.

Looking forward to your input!

@lmvysakh
Copy link

Hy @pablopicasso111,

Thank you for your feedback and for providing the code snippet. The screenshot of the workflow run is given as of below:

Image

We have tried running the workflow from our end using the code you shared, and it executed successfully without any errors. To help us better understand and resolve your issue, could you please provide more details about the problems you are encountering? Specifically, it would be helpful if you could:

  1. List out the exact error messages or issues you are facing
  2. Explain the steps you followed that led to the problem

This information will help us investigate further and assist you more effectively. Thank you!

@lmvysakh
Copy link

Hi @a-b,

This is a friendly reminder that we have not yet received any additional details, relevant workflow runs, or logs from your end, nor have we seen an explanation of the specific problem you’re encountering. Sharing these details would be extremely helpful and allow us to continue our investigation more effectively.

Moreover, Rewriting the setup-node action as a shell script might seem like a straightforward solution to remove the dependency on Node.js for initial installation, but there are several reasons why we have chosen to implement it in Node.js. The setup-node action’s advanced features, cross-platform support, maintainability, and integration with the Actions ecosystem make Node.js a more practical and robust choice for this action.

Also, If you could provide the above mentioned information at your earliest convenience, we’d be happy to assist further. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants