Skip to content

Node.js Default Version Not LTS #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fishcharlie opened this issue Apr 20, 2020 · 1 comment · Fixed by #141
Closed

Node.js Default Version Not LTS #140

fishcharlie opened this issue Apr 20, 2020 · 1 comment · Fixed by #141
Assignees
@bryanmacfarlane
Labels
bug Something isn't working

Comments

@fishcharlie
Copy link
Contributor

setup-node/action.yml

Lines 8 to 10 in 339aa41

node-version:
description: 'Version Spec of the version to use. Examples: 10.x, 10.15.1, >=10.15.0'
default: '10.x'

Is there a reason that the default version for node-version is not the latest LTS version ie. 12.x? Seems like that would be a more reasonable exception for this workflow.
@fishcharlie fishcharlie mentioned this issue Apr 20, 2020
Merged
@bryanmacfarlane bryanmacfarlane self-assigned this Apr 24, 2020
@bryanmacfarlane
Copy link
Member

I'll fix this. Actually, it shouldn't even have a default since the intended behavior was to be able to use without installing node by not supplying a value (thus using node globally installed on machine). That allows for action still setting up problem matchers etc.

https://github.com/actions/setup-node/blob/master/src/setup-node.ts#L11

Since I can't remove in v1 without affecting existing users, I will bump to 12.x in v1 and the upcoming v2 lineage will fix this by not have a default at all.

@bryanmacfarlane bryanmacfarlane added the bug Something isn't working label Apr 24, 2020
deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
@rugk @EndBug
Add instructions on how to user a different user (actions#140)

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
7451ee8 
* Add instructions on how to user a different user

* Fix wording

* Use special GitHub-provided mail for push examples

* Apply suggestions from code review

Co-authored-by: Federico Grandi <fgrandi30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanmacfarlane bryanmacfarlane

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changing node-version default to be latest LTS (12.x) fishcharlie/setup-node
2 participants
@fishcharlie @bryanmacfarlane