feat: support private mirrors #1240
Conversation
|
the failures dont seem related to this change are they? |
|
Hello @marco-ippolito, Thank you for your pull request! We are currently reviewing it. To resolve the check failures, could you please rebase your branch with the main branch and push the changes. |
|
@aparnajyothi-y thanks, rebased |
|
Hello marco-ippolito, |
|
@aparnajyothi-y change the message to |
marco-ippolito
force-pushed
the
mirror
branch
2 times, most recently
from
248ba43 to
40509ec
Compare
|
I wonder if we can merge this |
|
Hello @marco-ippolito, With the latest commit, the log message now correctly displays the mirror URL when provided, which is the expected behavior. However, in the default fallback scenario (when no mirror URL is provided), the log message currently shows: "Falling back to download directly from." Instead, it should remain as it was previously, showing: "Falling back to download directly from Node." |
|
@aparnajyothi-y thanks I have updated the code |
|
Hello @marco-ippolito, With the latest commit, the log message still showing: "Falling back to download directly from" Instead, it should remain as it was previously, showing: "Falling back to download directly from Node" |
|
@aparnajyothi-y amended |
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.3.0 to 4.4.0. Release notes *Sourced from [actions/setup-node's releases](https://github.com/actions/setup-node/releases).* > v4.4.0 > ------ > > What's Changed > -------------- > > ### Bug fixes: > > * Make eslint-compact matcher compatible with Stylelint by [`@FloEdelmann`](https://github.com/FloEdelmann) in [actions/setup-node#98](https://redirect.github.com/actions/setup-node/pull/98) > * Add support for indented eslint output by [`@fregante`](https://github.com/fregante) in [actions/setup-node#1245](https://redirect.github.com/actions/setup-node/pull/1245) > > ### Enhancement: > > * Support private mirrors by [`@marco-ippolito`](https://github.com/marco-ippolito) in [actions/setup-node#1240](https://redirect.github.com/actions/setup-node/pull/1240) > > ### Dependency update: > > * Upgrade `@action/cache` from 4.0.2 to 4.0.3 by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-node#1262](https://redirect.github.com/actions/setup-node/pull/1262) > > New Contributors > ---------------- > > * [`@FloEdelmann`](https://github.com/FloEdelmann) made their first contribution in [actions/setup-node#98](https://redirect.github.com/actions/setup-node/pull/98) > * [`@fregante`](https://github.com/fregante) made their first contribution in [actions/setup-node#1245](https://redirect.github.com/actions/setup-node/pull/1245) > * [`@marco-ippolito`](https://github.com/marco-ippolito) made their first contribution in [actions/setup-node#1240](https://redirect.github.com/actions/setup-node/pull/1240) > > **Full Changelog**: <actions/setup-node@v4...v4.4.0> Commits * [`49933ea`](actions/setup-node@49933ea) Bump `@action/cache` from 4.0.2 to 4.0.3 ([#1262](https://redirect.github.com/actions/setup-node/issues/1262)) * [`e3ce749`](actions/setup-node@e3ce749) feat: support private mirrors ([#1240](https://redirect.github.com/actions/setup-node/issues/1240)) * [`40337cb`](actions/setup-node@40337cb) Add support for indented eslint output ([#1245](https://redirect.github.com/actions/setup-node/issues/1245)) * [`1ccdddc`](actions/setup-node@1ccdddc) Make eslint-compact matcher compatible with Stylelint ([#98](https://redirect.github.com/actions/setup-node/issues/98)) * See full diff in [compare view](actions/setup-node@cdca736...49933ea) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Fixes: #1150
Fixes: #730