Make eslint-compact matcher compatible with Stylelint #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really want this update! 🙏 |
|
any interest in updating PR to target main instead of master? |
|
@bryanmacfarlane Done 👌 |
|
krzyk
pushed a commit
to krzyk/setup-node
that referenced
this pull request
Apr 11, 2023
[Fix] Creating sandbox from recipe with CPCode is not using provided CPCode
|
Friendly ping 🏓 |
priyagupta108
approved these changes
Mar 21, 2025
priya-kinthali
approved these changes
Mar 21, 2025
aparnajyothi-y
approved these changes
Mar 21, 2025
szepeviktor
approved these changes
Mar 21, 2025
HarithaVattikuti
approved these changes
Mar 24, 2025
mergify bot
added a commit
to ArcadeData/arcadedb
that referenced
this pull request
Apr 20, 2025
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.3.0 to 4.4.0. Release notes *Sourced from [actions/setup-node's releases](https://github.com/actions/setup-node/releases).* > v4.4.0 > ------ > > What's Changed > -------------- > > ### Bug fixes: > > * Make eslint-compact matcher compatible with Stylelint by [`@FloEdelmann`](https://github.com/FloEdelmann) in [actions/setup-node#98](https://redirect.github.com/actions/setup-node/pull/98) > * Add support for indented eslint output by [`@fregante`](https://github.com/fregante) in [actions/setup-node#1245](https://redirect.github.com/actions/setup-node/pull/1245) > > ### Enhancement: > > * Support private mirrors by [`@marco-ippolito`](https://github.com/marco-ippolito) in [actions/setup-node#1240](https://redirect.github.com/actions/setup-node/pull/1240) > > ### Dependency update: > > * Upgrade `@action/cache` from 4.0.2 to 4.0.3 by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-node#1262](https://redirect.github.com/actions/setup-node/pull/1262) > > New Contributors > ---------------- > > * [`@FloEdelmann`](https://github.com/FloEdelmann) made their first contribution in [actions/setup-node#98](https://redirect.github.com/actions/setup-node/pull/98) > * [`@fregante`](https://github.com/fregante) made their first contribution in [actions/setup-node#1245](https://redirect.github.com/actions/setup-node/pull/1245) > * [`@marco-ippolito`](https://github.com/marco-ippolito) made their first contribution in [actions/setup-node#1240](https://redirect.github.com/actions/setup-node/pull/1240) > > **Full Changelog**: <actions/setup-node@v4...v4.4.0> Commits * [`49933ea`](actions/setup-node@49933ea) Bump `@action/cache` from 4.0.2 to 4.0.3 ([#1262](https://redirect.github.com/actions/setup-node/issues/1262)) * [`e3ce749`](actions/setup-node@e3ce749) feat: support private mirrors ([#1240](https://redirect.github.com/actions/setup-node/issues/1240)) * [`40337cb`](actions/setup-node@40337cb) Add support for indented eslint output ([#1245](https://redirect.github.com/actions/setup-node/issues/1245)) * [`1ccdddc`](actions/setup-node@1ccdddc) Make eslint-compact matcher compatible with Stylelint ([#98](https://redirect.github.com/actions/setup-node/issues/98)) * See full diff in [compare view](actions/setup-node@cdca736...49933ea) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stylelint has a
compactformatter that is (nearly) compatible with ESLint one's.It outputs lowercase severity strings though, so
eslint-compactmatcher's RegExp is not triggered.This PR changes the matcher to also match lowercase severity strings.
Alternatively, the matcher could be duplicated as
stylelint-compactand both RegExps could target exact lowercase/uppercase severities.Example check run containing Stylelint output: https://github.com/OpenLightingProject/open-fixture-library/pull/1163/checks?check_run_id=365592295