Skip to content

CHORE: Ansys version warning vs grpc #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 90 commits into from
Jul 11, 2025
Merged

Conversation

svandenb-dev
Copy link
Collaborator

This PR is adding deprecation warning with respect to PyEDB DotNet vs gRPC.

# Conflicts:
#	src/pyedb/grpc/database/layout/layout.py
# Conflicts:
#	src/pyedb/configuration/cfg_setup.py
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.17%. Comparing base (d256bb9) to head (d8facc5).

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   76.17%   76.17%   -0.01%     
==========================================
  Files         162      163       +1     
  Lines       23806    23818      +12     
==========================================
+ Hits        18135    18143       +8     
- Misses       5671     5675       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev requested a review from gkorompi June 20, 2025 06:58
gkorompi
gkorompi previously approved these changes Jun 20, 2025
SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 20, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left two minor comments

@svandenb-dev svandenb-dev dismissed stale reviews from SMoraisAnsys and gkorompi via 315c7bf July 4, 2025 14:11
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left minor comments. Seems fine once handled !

svandenb-dev and others added 2 commits July 8, 2025 14:26
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@gkorompi gkorompi self-requested a review July 9, 2025 12:13
gkorompi
gkorompi previously approved these changes Jul 9, 2025
@gkorompi gkorompi self-requested a review July 9, 2025 12:39
gkorompi
gkorompi previously approved these changes Jul 9, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 2ccfd87 into main Jul 11, 2025
38 of 39 checks passed
@svandenb-dev svandenb-dev deleted the ansys-version-warning-vs-grpc branch July 11, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants