-
Notifications
You must be signed in to change notification settings - Fork 13
CHORE: Ansys version warning vs grpc #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/pyedb/grpc/database/layout/layout.py
# Conflicts: # src/pyedb/configuration/cfg_setup.py
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
- Coverage 76.17% 76.17% -0.01%
==========================================
Files 162 163 +1
Lines 23806 23818 +12
==========================================
+ Hits 18135 18143 +8
- Misses 5671 5675 +4 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left two minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left minor comments. Seems fine once handled !
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
For more information, see https://pre-commit.ci
…nto ansys-version-warning-vs-grpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is adding deprecation warning with respect to PyEDB DotNet vs gRPC.