brought back uint8_t for most 8bit samples

Author: mrpossoms

AudioFile.h

@@ -212,9 +212,10 @@ class AudioFile
 
     //=============================================================
     int8_t sampleToSingleByte (T sample);
+public:
     T singleByteToSample (uint8_t sample);
     T singleByteToSample (int8_t sample);
-
+private:
     uint32_t getAiffSampleRate (std::vector<uint8_t>& fileData, int sampleRateStartIndex);
     bool tenByteMatch (std::vector<uint8_t>& v1, int startIndex1, std::vector<uint8_t>& v2, int startIndex2);
     void addSampleRateToAiffData (std::vector<uint8_t>& fileData, uint32_t sampleRate);
@@ -945,7 +946,7 @@ bool AudioFile<T>::saveToWaveFile (std::string filePath)
         {
             if (bitDepth == 8)
             {
-                int8_t byte = sampleToSingleByte (samples[channel][i]);
+                uint8_t byte = sampleToSingleByte (samples[channel][i]);
                 fileData.push_back (byte);
             }
             else if (bitDepth == 16)
@@ -1055,7 +1056,7 @@ bool AudioFile<T>::saveToAiffFile (std::string filePath)
         {
             if (bitDepth == 8)
             {
-                int8_t byte = sampleToSingleByte (samples[channel][i]);
+                uint8_t byte = sampleToSingleByte (samples[channel][i]);
                 fileData.push_back (byte);
             }
             else if (bitDepth == 16)
@@ -1384,7 +1385,7 @@ T AudioFile<T>::singleByteToSample (uint8_t sample)
 {
     if (std::is_floating_point<T>::value)
     {
-        return static_cast<T> (sample - 128) / static_cast<T> (128.);
+        return static_cast<T> (static_cast<int>(sample) - 128) / static_cast<T> (128.);
     }
 
     else if(std::numeric_limits<T>::is_integer)

tests/GeneralTests.cpp

@@ -111,6 +111,17 @@ TEST_SUITE ("General Tests")
         CHECK_EQ (resampleIntegerSample<int8_t, int16_t>(-128), -32768);
     }
 
+    //=============================================================
+    TEST_CASE ("GeneralTests::SingleByteToSample")
+    {
+        AudioFile<double> dummy;
+
+        CHECK_EQ (dummy.singleByteToSample((uint8_t)128), 0);
+        CHECK_EQ (dummy.singleByteToSample((int8_t)0), 0);
+
+        CHECK (dummy.singleByteToSample((uint8_t)255) == doctest::Approx (1).epsilon (0.05));
+        CHECK (dummy.singleByteToSample((uint8_t)0) == doctest::Approx (-1).epsilon (0.05));
+    }
     //=============================================================
     TEST_CASE ("GeneralTests::IntegerFormat")
     {