Attempt to fix the test

Author: Aiqiao Yan

packages/cache/package-lock.json

@@ -44,6 +44,7 @@
     "uuid": "^3.3.3"
   },
   "devDependencies": {
+    "typescript": "^3.8.3",
     "@types/uuid": "^3.4.5"
   }
 }

packages/cache/package.json

@@ -5,23 +5,39 @@ import * as cacheHttpClient from './internal/cacheHttpClient'
 import {createTar, extractTar} from './internal/tar'
 import {UploadOptions} from './options'
 
+export class ValidationError extends Error {
+  constructor(message: string) {
+    super(message)
+    this.name = 'ValidationError'
+  }
+}
+
+export class ReserveCacheError extends Error {
+  constructor(message: string) {
+    super(message)
+    this.name = 'ReserveCacheError'
+  }
+}
+
 function checkPaths(paths: string[]): void {
   if (!paths || paths.length === 0) {
-    throw new Error(
+    throw new ValidationError(
       `Path Validation Error: At least one directory or file path is required`
     )
   }
 }
 
 function checkKey(key: string): void {
   if (key.length > 512) {
-    throw new Error(
+    throw new ValidationError(
       `Key Validation Error: ${key} cannot be larger than 512 characters.`
     )
   }
   const regex = /^[^,]*$/
   if (!regex.test(key)) {
-    throw new Error(`Key Validation Error: ${key} cannot contain commas.`)
+    throw new ValidationError(
+      `Key Validation Error: ${key} cannot contain commas.`
+    )
   }
 }
 
@@ -47,7 +63,7 @@ export async function restoreCache(
   core.debug(JSON.stringify(keys))
 
   if (keys.length > 10) {
-    throw new Error(
+    throw new ValidationError(
       `Key Validation Error: Keys are limited to a maximum of 10.`
     )
   }
@@ -121,13 +137,13 @@ export async function saveCache(
     compressionMethod
   })
   if (cacheId === -1) {
-    throw new Error(
+    throw new ReserveCacheError(
       `Unable to reserve cache with key ${key}, another job may be creating this cache.`
     )
   }
   core.debug(`Cache ID: ${cacheId}`)
-  const cachePaths = await utils.resolvePaths(paths)
 
+  const cachePaths = await utils.resolvePaths(paths)
   core.debug('Cache Paths:')
   core.debug(`${JSON.stringify(cachePaths)}`)
 

packages/cache/src/cache.ts

@@ -15,7 +15,7 @@ import * as utils from './cacheUtils'
 import {CompressionMethod, SocketTimeout} from './constants'
 import {
   ArtifactCacheEntry,
-  CacheOptions,
+  InternalCacheOptions,
   CommitCacheRequest,
   ReserveCacheRequest,
   ReserveCacheResponse
@@ -180,7 +180,7 @@ export async function retryHttpClientResponse<T>(
 export async function getCacheEntry(
   keys: string[],
   paths: string[],
-  options?: CacheOptions
+  options?: InternalCacheOptions
 ): Promise<ArtifactCacheEntry | null> {
   const httpClient = createHttpClient()
   const version = getCacheVersion(paths, options?.compressionMethod)
@@ -258,7 +258,7 @@ export async function downloadCache(
 export async function reserveCache(
   key: string,
   paths: string[],
-  options?: CacheOptions
+  options?: InternalCacheOptions
 ): Promise<number> {
   const httpClient = createHttpClient()
   const version = getCacheVersion(paths, options?.compressionMethod)

packages/cache/src/internal/cacheHttpClient.ts

@@ -20,6 +20,6 @@ export interface ReserveCacheResponse {
   cacheId: number
 }
 
-export interface CacheOptions {
+export interface InternalCacheOptions {
   compressionMethod?: CompressionMethod
 }