Skip to content

feat: French, Russian, and Korean translations #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

AmitChauhan63390
Copy link
Contributor

@AmitChauhan63390 AmitChauhan63390 commented Jun 22, 2025

#651

Summary by CodeRabbit

  • New Features

    • Added full French, Russian, and Korean language support across the application.
    • Extended the language selection menu with new options for Korean, French, and Russian.
  • Improvements

    • Refined and clarified German, Spanish, Japanese, and Chinese translations for improved consistency and user experience.
    • Enhanced English localization formatting and added new language entries to the language menu.

Copy link

coderabbitai bot commented Jun 22, 2025

Walkthrough

This update expands and refines the application's localization support. It introduces comprehensive French, Russian, and Korean translation files, improves existing German, Spanish, Japanese, and Chinese localizations, and standardizes the English localization file. The language selection UI and i18n configuration are updated to support the new languages, with no changes to core logic or exported entities.

Changes

Files / Group Change Summary
public/locales/de.json, es.json, ja.json, zh.json Extensive textual refinements for clarity, consistency, and completeness in German, Spanish, Japanese, and Chinese localizations.
public/locales/en.json Reformatted for consistent indentation and spacing; added new languages to the language menu.
public/locales/fr.json, ko.json, ru.json Added new comprehensive localization files for French, Korean, and Russian.
src/components/dashboard/NavBar.tsx Added French, Russian, and Korean options to the language selection menu.
src/i18n.ts Updated supported languages list to include French, Russian, and Korean.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NavBar
    participant i18n
    participant LocaleFiles

    User->>NavBar: Opens language menu
    NavBar->>User: Shows language options (incl. fr, ru, ko)
    User->>NavBar: Selects a new language (e.g., Russian)
    NavBar->>i18n: changeLanguage('ru')
    i18n->>LocaleFiles: Loads ru.json
    i18n->>NavBar: Updates UI with Russian translations
    NavBar->>User: UI displayed in Russian
Loading

Possibly related PRs

Suggested labels

Type: Enhancement, Scope: UI/UX

Poem

🐇
New tongues arrive, the world grows wide,
French, Korean, Russian—side by side!
Old words polished, new ones spun,
Now Maxun speaks to everyone.
A hop, a skip, a global cheer—
Languages bloom, translation’s here!
🌍✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/i18n.ts (1)

13-13: Suggest alphabetical sorting of supported languages
Consider ordering the supportedLngs array alphabetically and ensuring consistent spacing for readability:

- supportedLngs: ['en', 'es', 'ja', 'zh','de','fr','ru','ko'],
+ supportedLngs: ['de', 'en', 'es', 'fr', 'ja', 'ko', 'ru', 'zh'],
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37cdb9c and cabee15.

📒 Files selected for processing (10)
  • public/locales/de.json (1 hunks)
  • public/locales/en.json (1 hunks)
  • public/locales/es.json (12 hunks)
  • public/locales/fr.json (1 hunks)
  • public/locales/ja.json (1 hunks)
  • public/locales/ko.json (1 hunks)
  • public/locales/ru.json (1 hunks)
  • public/locales/zh.json (15 hunks)
  • src/components/dashboard/NavBar.tsx (1 hunks)
  • src/i18n.ts (1 hunks)
🔇 Additional comments (16)
public/locales/en.json (1)

611-620: Approve new language menu entries
New entries for Russian, French, and Korean in the language_menu align with the updated supportedLngs configuration.

public/locales/fr.json (1)

1-621: Comprehensive French localization added
The new fr.json includes all expected keys matching the structure of existing locale files with accurate translations.

public/locales/ko.json (1)

1-622: Comprehensive Korean localization added
The new ko.json file covers the full set of UI keys and placeholders, consistent with other locales.

public/locales/ru.json (1)

1-622: Comprehensive Russian localization added
The new ru.json file mirrors the structure of the other locale files and provides full translations.

src/i18n.ts (1)

13-13: Supports new locales
The supportedLngs array is correctly updated to include 'fr', 'ru', and 'ko', matching the added locale files.

src/components/dashboard/NavBar.tsx (3)

471-478: Add Korean language option to navigation menu.

The new MenuItem for "ko" matches the pattern of existing language items. Ensure that "ko" is included in the supported languages list in src/i18n.ts and that the corresponding public/locales/ko.json file exists and contains the expected translations.


479-486: Add French language option to navigation menu.

The new MenuItem for "fr" is consistent with existing entries. Please confirm that "fr" is registered in the i18n configuration and that public/locales/fr.json has been added.


487-494: Add Russian language option to navigation menu.

The MenuItem for "ru" follows the established pattern. Verify that "ru" appears in your i18n.ts setup and that public/locales/ru.json exists with complete translations.

public/locales/es.json (2)

1-621: Approve Spanish translation refinements.

All key refinements through the file maintain consistency in style, punctuation, and placeholders. No structural changes were introduced.


616-620: Extend language menu with new languages.

The language_menu block now includes "ru", "fr", and "ko", aligning with the UI updates in NavBar.tsx. Confirm these entries match those in other locale files.

public/locales/ja.json (2)

1-621: Approve Japanese translation refinements.

Textual updates improve clarity and consistency. Placeholder syntax remains correct and keys are unchanged.


611-620: Extend language menu with new languages.

The Japanese locale now lists "ru", "fr", and "ko" under language_menu. Ensure this aligns with the entries in NavBar.tsx and the overall i18n config.

public/locales/zh.json (2)

1-621: Approve Chinese translation refinements.

All modifications maintain existing JSON structure and placeholder consistency.


616-620: Extend language menu with new languages.

Chinese locale’s language_menu now includes "ru", "fr", and "ko". Confirm that the keys and display names match the rest of the application.

public/locales/de.json (2)

1-621: Approve German translation refinements.

Phrasing improvements and added warning modals are consistent. No key changes or missing placeholders detected.


616-620: Extend language menu with new languages.

The German locale’s language_menu now includes "ru", "fr", and "ko". Verify that these entries correspond exactly to the UI labels used in NavBar.tsx and other locales.

@amhsirak amhsirak changed the title Languages enhancement: add missing translations Jun 22, 2025
@amhsirak amhsirak changed the title enhancement: add missing translations feat: French, Russian, and Korean translations Jun 23, 2025
@amhsirak amhsirak added the Scope: i18n Translations All issues/PRs related to language translations label Jun 23, 2025
@amhsirak amhsirak requested a review from RohitR311 July 3, 2025 09:39
@amhsirak
Copy link
Member

amhsirak commented Jul 3, 2025

@AmitChauhan63390 resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: i18n Translations All issues/PRs related to language translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants