-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: French, Russian, and Korean translations #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
fix: date format for duplicate robots
chore: release v0.0.14
chore: release v0.0.15
chore: release v0.0.16
WalkthroughThis update expands and refines the application's localization support. It introduces comprehensive French, Russian, and Korean translation files, improves existing German, Spanish, Japanese, and Chinese localizations, and standardizes the English localization file. The language selection UI and i18n configuration are updated to support the new languages, with no changes to core logic or exported entities. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NavBar
participant i18n
participant LocaleFiles
User->>NavBar: Opens language menu
NavBar->>User: Shows language options (incl. fr, ru, ko)
User->>NavBar: Selects a new language (e.g., Russian)
NavBar->>i18n: changeLanguage('ru')
i18n->>LocaleFiles: Loads ru.json
i18n->>NavBar: Updates UI with Russian translations
NavBar->>User: UI displayed in Russian
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/i18n.ts (1)
13-13
: Suggest alphabetical sorting of supported languages
Consider ordering thesupportedLngs
array alphabetically and ensuring consistent spacing for readability:- supportedLngs: ['en', 'es', 'ja', 'zh','de','fr','ru','ko'], + supportedLngs: ['de', 'en', 'es', 'fr', 'ja', 'ko', 'ru', 'zh'],
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
public/locales/de.json
(1 hunks)public/locales/en.json
(1 hunks)public/locales/es.json
(12 hunks)public/locales/fr.json
(1 hunks)public/locales/ja.json
(1 hunks)public/locales/ko.json
(1 hunks)public/locales/ru.json
(1 hunks)public/locales/zh.json
(15 hunks)src/components/dashboard/NavBar.tsx
(1 hunks)src/i18n.ts
(1 hunks)
🔇 Additional comments (16)
public/locales/en.json (1)
611-620
: Approve new language menu entries
New entries for Russian, French, and Korean in thelanguage_menu
align with the updatedsupportedLngs
configuration.public/locales/fr.json (1)
1-621
: Comprehensive French localization added
The newfr.json
includes all expected keys matching the structure of existing locale files with accurate translations.public/locales/ko.json (1)
1-622
: Comprehensive Korean localization added
The newko.json
file covers the full set of UI keys and placeholders, consistent with other locales.public/locales/ru.json (1)
1-622
: Comprehensive Russian localization added
The newru.json
file mirrors the structure of the other locale files and provides full translations.src/i18n.ts (1)
13-13
: Supports new locales
ThesupportedLngs
array is correctly updated to include 'fr', 'ru', and 'ko', matching the added locale files.src/components/dashboard/NavBar.tsx (3)
471-478
: Add Korean language option to navigation menu.The new
MenuItem
for"ko"
matches the pattern of existing language items. Ensure that"ko"
is included in the supported languages list insrc/i18n.ts
and that the correspondingpublic/locales/ko.json
file exists and contains the expected translations.
479-486
: Add French language option to navigation menu.The new
MenuItem
for"fr"
is consistent with existing entries. Please confirm that"fr"
is registered in the i18n configuration and thatpublic/locales/fr.json
has been added.
487-494
: Add Russian language option to navigation menu.The
MenuItem
for"ru"
follows the established pattern. Verify that"ru"
appears in youri18n.ts
setup and thatpublic/locales/ru.json
exists with complete translations.public/locales/es.json (2)
1-621
: Approve Spanish translation refinements.All key refinements through the file maintain consistency in style, punctuation, and placeholders. No structural changes were introduced.
616-620
: Extend language menu with new languages.The
language_menu
block now includes"ru"
,"fr"
, and"ko"
, aligning with the UI updates inNavBar.tsx
. Confirm these entries match those in other locale files.public/locales/ja.json (2)
1-621
: Approve Japanese translation refinements.Textual updates improve clarity and consistency. Placeholder syntax remains correct and keys are unchanged.
611-620
: Extend language menu with new languages.The Japanese locale now lists
"ru"
,"fr"
, and"ko"
underlanguage_menu
. Ensure this aligns with the entries inNavBar.tsx
and the overall i18n config.public/locales/zh.json (2)
1-621
: Approve Chinese translation refinements.All modifications maintain existing JSON structure and placeholder consistency.
616-620
: Extend language menu with new languages.Chinese locale’s
language_menu
now includes"ru"
,"fr"
, and"ko"
. Confirm that the keys and display names match the rest of the application.public/locales/de.json (2)
1-621
: Approve German translation refinements.Phrasing improvements and added warning modals are consistent. No key changes or missing placeholders detected.
616-620
: Extend language menu with new languages.The German locale’s
language_menu
now includes"ru"
,"fr"
, and"ko"
. Verify that these entries correspond exactly to the UI labels used inNavBar.tsx
and other locales.
@AmitChauhan63390 resolve conflicts |
#651
Summary by CodeRabbit
New Features
Improvements