-
Notifications
You must be signed in to change notification settings - Fork 351
Open
Labels
package:cellsRequests related to the cells packageRequests related to the cells packagepackage:coreRequests related to the core packageRequests related to the core packagetype:enhancementRequests for enhancements or new featuresRequests for enhancements or new features
Metadata
Metadata
Assignees
Labels
package:cellsRequests related to the cells packageRequests related to the cells packagepackage:coreRequests related to the core packageRequests related to the core packagetype:enhancementRequests for enhancements or new featuresRequests for enhancements or new features
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
jassmith commentedon Dec 29, 2023
I think option 1 is the way to go if react number format supports it. Have you a usecase for bigint data?
lukasmasuch commentedon Dec 29, 2023
yeah, users have run into this a couple of times mostly related to columns that contain numerical IDs. And timestamps and time durations are sometimes represented in nanoseconds... which can easily overflow Number
jassmith commentedon Jan 2, 2024
It looks like to make this possible we would need to swap out the editor implementation. react-number-format does not support this.
lukasmasuch commentedon Jan 2, 2024
I think
react-number-format
should be fine with handling larger numbers. E.g.9007199254740992
is the highest supported value for Number without losing precision. In this demo, if you go higher thefloatValue
will lose precision but the stringvalue
will show the correct number:Screen.Recording.2024-01-02.at.17.00.54.mov
This means, that we would need to handle the value as a string for the
react-number-format
input field if the cell data is a bigint.jassmith commentedon Jan 2, 2024
Oh very nice. Okay Im on board with this.