Skip to content

Update exported drawTextCell to handle wrapping. #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

infalmo
Copy link
Contributor

@infalmo infalmo commented May 10, 2025

No description provided.

@lukasmasuch lukasmasuch requested a review from Copilot June 17, 2025 19:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds optional wrapping behavior to the external drawTextCell API by extending its signature and forwarding new parameters.

  • Extended drawTextCellExternal signature with allowWrapping and hyperWrapping flags
  • Updated the call into the internal drawTextCell to pass through the new flags
Comments suppressed due to low confidence (2)

packages/core/src/internal/data-grid/render/data-grid-lib.ts:447

  • Update the JSDoc above drawTextCellExternal to document the new allowWrapping and hyperWrapping parameters, including their default behaviors.
export function drawTextCellExternal(

packages/core/src/internal/data-grid/render/data-grid-lib.ts:451

  • Add unit tests for drawTextCellExternal when allowWrapping is true and false, as well as for hyperWrapping, to ensure the new wrapping logic is exercised.
    allowWrapping?: boolean,

@lukasmasuch
Copy link
Collaborator

LGTM 👍 @BrianHung do you see any reason why not to expose these options in the exported function?

@BrianHung
Copy link
Collaborator

Nope, LGTM!

Copy link
Collaborator

@BrianHung BrianHung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows developers to use allowWrapping and hyperWrapping options.

Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukasmasuch lukasmasuch merged commit 5795ea7 into glideapps:main Jun 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants