BC-9425 Update and remove packages (#5634)

includes workaround to allow dependencies
see actions/dependency-review-action#868

Author: dyedwiper

.github/workflows/dependency-review.yml

@@ -31,4 +31,7 @@ jobs:
             CC0-1.0
           allow-ghsas: 'GHSA-vxvm-qww3-2fh7'
           # https://github.com/actions/dependency-review-action/issues/868
-          allow-dependencies-licenses: pkg:npm/%40apidevtools/json-schema-ref-parser@11.7.3
+          allow-dependencies-licenses: >
+            pkg:npm/%40apidevtools/json-schema-ref-parser@11.7.3,
+            pkg:npm/fishery@2.2.3,
+            pkg:npm/nest-winston@1.10.2

.knip.json

@@ -0,0 +1,5 @@
+{
+	"$schema": "https://unpkg.com/knip@5/schema.json",
+	"entry": ["src/app.js!", "apps/server/src/apps/*.ts!", "apps/server/src/migrations/**/*.ts!", "scripts/*.js!"],
+	"project": ["**/*.{js,ts}!"]
+}

apps/server/src/modules/board/domain/type-mapping.ts

@@ -38,7 +38,7 @@ const BoardNodeTypeToConstructor = {
 	[BoardNodeType.DELETED_ELEMENT]: DeletedElement,
 } as const;
 
-export const getBoardNodeConstructor = <T extends BoardNodeType>(type: T): typeof BoardNodeTypeToConstructor[T] =>
+export const getBoardNodeConstructor = <T extends BoardNodeType>(type: T): (typeof BoardNodeTypeToConstructor)[T] =>
 	BoardNodeTypeToConstructor[type];
 
 export const getBoardNodeType = <T extends AnyBoardNode>(boardNode: T): BoardNodeType => {

apps/server/src/modules/common-cartridge/common-cartridge-client/lesson-client/dto/lesson-contents.dto.ts

@@ -28,4 +28,4 @@ export const LessonContentDtoComponentValues = {
 } as const;
 
 export type LessonContentDtoComponent =
-	typeof LessonContentDtoComponentValues[keyof typeof LessonContentDtoComponentValues];
+	(typeof LessonContentDtoComponentValues)[keyof typeof LessonContentDtoComponentValues];

apps/server/src/modules/common-cartridge/common-cartridge-client/lesson-client/dto/lesson-linked-task.dto.ts

@@ -47,4 +47,4 @@ export const LessonLinkedTaskDescriptionInputFormat = {
 } as const;
 
 export type LessonLinkedTaskDescriptionInputFormatType =
-	typeof LessonLinkedTaskDescriptionInputFormat[keyof typeof LessonLinkedTaskDescriptionInputFormat];
+	(typeof LessonLinkedTaskDescriptionInputFormat)[keyof typeof LessonLinkedTaskDescriptionInputFormat];

apps/server/src/modules/common-cartridge/common-cartridge-client/room-client/room-client.adapter.spec.ts

@@ -4,7 +4,6 @@ import { REQUEST } from '@nestjs/core';
 import { faker } from '@faker-js/faker';
 import { Request } from 'express';
 import { AxiosResponse } from 'axios';
-import { jest } from '@jest/globals';
 import { CourseRoomsApi, SingleColumnBoardResponse } from './room-api-client';
 import { CourseRoomsClientAdapter } from './room-client.adapter';
 import { RoomBoardDtoMapper } from './mapper/room-board-dto.mapper';

apps/server/src/modules/news/api/dto/news.response.ts

@@ -9,7 +9,7 @@ import { UserInfoResponse } from './user-info.response';
 const NEWS_SOURCES = ['internal', 'rss'] as const;
 const TARGET_MODEL_VALUES = Object.values(NewsTargetModel);
 
-type SourceType = typeof NEWS_SOURCES[number];
+type SourceType = (typeof NEWS_SOURCES)[number];
 export class NewsResponse {
 	constructor({
 		id,

apps/server/src/modules/role/domain/type/rolename.enum.ts

@@ -41,7 +41,7 @@ export const RoomRoleArray = [
 	RoleName.ROOMEDITOR,
 	RoleName.ROOMVIEWER,
 ] as const;
-export type RoomRole = typeof RoomRoleArray[number];
+export type RoomRole = (typeof RoomRoleArray)[number];
 
 export const GuestRoleArray = [RoleName.GUESTSTUDENT, RoleName.GUESTTEACHER] as const;
-export type GuestRole = typeof GuestRoleArray[number];
+export type GuestRole = (typeof GuestRoleArray)[number];

apps/server/src/modules/task/api/dto/task.response.ts

@@ -46,7 +46,6 @@ export class TaskResponse {
 		description: 'Task description object, with props content: string and type: input format types',
 		type: RichText,
 	})
-	@DecodeHtmlEntities()
 	description?: RichText;
 
 	@ApiProperty()

apps/server/src/modules/task/domain/type/rich-text.types.ts

@@ -1,4 +1,5 @@
 import { ApiProperty } from '@nestjs/swagger';
+import { DecodeHtmlEntities } from '@shared/controller/transformer';
 import { sanitizeRichText } from '@shared/controller/transformer/sanitize-html.transformer';
 import { InputFormat } from '@shared/domain/types/input-format.types';
 
@@ -11,6 +12,7 @@ export class RichText {
 	@ApiProperty({
 		description: 'Content of the rich text element',
 	})
+	@DecodeHtmlEntities()
 	content: string;
 
 	@ApiProperty({

apps/server/src/modules/user-import/uc/user-import.uc.spec.ts

@@ -897,7 +897,7 @@ describe('[ImportUserModule]', () => {
 				schoolServiceSpy = schoolService.getSchoolById.mockResolvedValue(createMockSchoolDo(school));
 				systemRepoSpy = systemService.findById.mockReturnValueOnce(Promise.resolve(systemDo));
 				config.FEATURE_USER_MIGRATION_SYSTEM_ID = system.id;
-				dateSpy = jest.spyOn(global, 'Date').mockReturnValue(currentDate as unknown as string);
+				dateSpy = jest.spyOn(global, 'Date').mockReturnValue(currentDate);
 			});
 
 			afterEach(() => {