add some more test cases

Author: joelharkes

.github/workflows/ci.yml

@@ -57,7 +57,7 @@ jobs:
         id: test-action
         uses: ./
         with:
-          ignoreDefault: true
+          ignoreDefault: false
 
       - name: Print Output
         id: output

__tests__/main.test.ts

@@ -15,12 +15,77 @@ jest.unstable_mockModule('@actions/core', () => core);
 // mocks are used in place of any actual dependencies.
 const { runAction } = await import('../src/main.js');
 
-test('run action', async () => {
+test('can run successfully', async () => {
   core.isDebug.mockReturnValue(false);
-  return runAction({
+  runAction({
     includeGitignore: false,
     ignoreDefault: false,
-    files: '',
+    files: `root/file1.js file.md`,
     allRulesMustHit: false,
+    codeownersContent: `
+    /root @owner3
+    *.md @owner4
+    `,
   });
+
+  // expect 4 group calls
+  expect(core.startGroup).toHaveBeenCalledTimes(5);
+  expect(core.endGroup).toHaveBeenCalledTimes(5);
+  expect(core.error).toHaveBeenCalledTimes(0);
+  expect(core.setOutput.mock.calls[0][0]).toBe('missedFiles');
+  expect(core.setOutput.mock.calls[0][1]).toBe(``);
+  expect(core.setFailed).toHaveBeenCalledTimes(0);
+});
+
+test('fails on missing files', async () => {
+  core.isDebug.mockReturnValue(false);
+  runAction({
+    includeGitignore: false,
+    ignoreDefault: true,
+    files: `root/file1.js file.js file.md any/file.md not/root/missed.js folder/file.js notroot/folder/file.js`,
+    allRulesMustHit: true,
+    codeownersContent: `#comment
+    * @all-ignored
+    folder @owner1
+    /root @owner3
+    *.md @owner4
+    `,
+  });
+
+  // expect 4 group calls
+  expect(core.startGroup).toHaveBeenCalledTimes(5);
+  expect(core.endGroup).toHaveBeenCalledTimes(5);
+  expect(core.error).toHaveBeenCalledTimes(2);
+  expect(core.error.mock.calls[0][1]!.file).toBe('/file.js');
+  expect(core.error.mock.calls[1][1]!.file).toBe('/not/root/missed.js');
+  expect(core.setOutput.mock.calls[0][0]).toBe('missedFiles');
+  expect(core.setOutput.mock.calls[0][1]).toBe(`/file.js\n/not/root/missed.js`);
+  expect(core.setFailed).toHaveBeenCalledTimes(1);
+});
+
+test('fails on unused codeowner rules', async () => {
+  core.isDebug.mockReturnValue(false);
+  runAction({
+    includeGitignore: false,
+    ignoreDefault: true,
+    files: `root/file.js file.md`,
+    allRulesMustHit: true,
+    codeownersContent: `#comment
+    * @all-ignored
+    folder @owner1
+    /root @owner3
+    *.md @owner4
+    `,
+  });
+
+  // expect 4 group calls
+  expect(core.startGroup).toHaveBeenCalledTimes(5);
+  expect(core.endGroup).toHaveBeenCalledTimes(5);
+  expect(core.error).toHaveBeenCalledTimes(1);
+  expect(core.error.mock.calls[0][1]!.file).toBe('CODEOWNERS');
+  expect(core.error.mock.calls[0][1]!.startLine).toBe(3);
+  expect(core.error.mock.calls[0][0]).toBe('Rule not used: folder');
+  expect(core.setOutput.mock.calls[0][0]).toBe('missedFiles');
+  expect(core.setOutput.mock.calls[0][1]).toBe(``);
+  expect(core.setFailed).toHaveBeenCalledTimes(1);
 });

badges/coverage.svg

@@ -33,7 +33,7 @@
     "package": "npx rollup --config rollup.config.ts --configPlugin @rollup/plugin-typescript",
     "package:watch": "npm run package -- --watch",
     "test": "NODE_OPTIONS=--experimental-vm-modules NODE_NO_WARNINGS=1 npx jest",
-    "all": "npm run format:write && npm run lint && npm run test && npm run coverage && npm run package"
+    "all": "npm run format:write && npm run lint -- --fix && npm run test && npm run coverage && npm run package"
   },
   "license": "MIT",
   "dependencies": {

dist/index.js

@@ -33,7 +33,8 @@ export const runAction = async (input: Input): Promise<void> => {
       .split(' ')
       .map((file) => (file.startsWith('/') ? file : `/${file}`));
   } else {
-    filesToCheck = await (await glob.create('*')).glob();
+    // glob all files except .git folder
+    filesToCheck = await (await glob.create('*\n!.git/**')).glob();
     if (input['includeGitignore'] === true) {
       core.info('Ignoring .gitignored files');
       let gitIgnoreFiles: string[] = [];