Add script to create the NuGet package from the online build artifacts #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulltoken
force-pushed
the
ntk/auto_package
branch
3 times, most recently
from
5be1949 to
768cbb9
Compare
nulltoken
changed the title
| return $output | ||
| } | ||
|
|
||
| function Extract-BuildIdentifier($statutes, $forContext) { |
There was a problem hiding this comment.
I can't help but think this whole function is written in a very clumsy way... Any refactoring proposal?
nulltoken
force-pushed
the
ntk/auto_package
branch
from
768cbb9 to
3b4eed1
Compare
| return $output | ||
| } | ||
|
|
||
| function Extract-BuildIdentifier($statutes, $forContext) { |
There was a problem hiding this comment.
Is there a way to make this more powershell-y?
There was a problem hiding this comment.
- Typo in variable name
$status = $statuses | where { $_.context -eq $forContext } | select -First 1?
There was a problem hiding this comment.
@dahlbyk Brilliant! ❤️ fixed
nulltoken
changed the title
nulltoken
referenced
this pull request
Oct 4, 2015
nulltoken
force-pushed
the
ntk/auto_package
branch
from
3b4eed1 to
da64485
Compare
nulltoken
added a commit
that referenced
this pull request
Oct 23, 2015
Add script to create the NuGet package from the online build artifacts
|
I know you just merged this in, but I just wanted to say that I finally had some time to check it out and it looks good to me! The only thing that you could do is add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22
PowerShell not being my forte, I'd be really grateful for an early feedback
/cc @bording @dahlbyk