Skip to content

feat(actions): improve error message for wrong actions #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Jan 20, 2025

This PR improves the error message when executing the "Open URL in browser" action, thus help users debug.

Close #259

Test Platforms

  • windows
  • macOS
  • linux

Test Hosts

Test Functions

  • Use GitLink(!) to copy git link (or open in browser).
  • Use GitLink(!) blame to copy the /blame link (or open in browser).
  • Use GitLink(!) default_branch to open the /main//master link in browser (or open in browser).
  • Use GitLink(!) current_branch to open the current branch link in browser (or open in browser).
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.
  • Copy git link with 'file' and 'rev' parameters.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.95%. Comparing base (296ad98) to head (5b4d420).

Files with missing lines Patch % Lines
lua/gitlinker/actions.lua 68.75% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   70.82%   72.95%   +2.13%     
==========================================
  Files          10       10              
  Lines         963      991      +28     
==========================================
+ Hits          682      723      +41     
+ Misses        281      268      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 deleted the improve-error branch January 21, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: actions.system doesn't work with custom routers
1 participant