OrdsSrvs secret vs password

[gotsysdba]

Mismatch between CustomResourceDefinition ordssrvs.database.oracle.com and other code/documentation.

CRD defines:

poolSettings:
 - db.secret:
   db.adminUser.secret
   db.cdb.adminUser.secret

Below code references db.password, db.adminUser.password, db.cdb.adminUser.password:

• apis/database/v4
• commons/database/constants.go
• ords/ords_init.sh
• ords/runOrdsSSL.sh

Documentation is a mismatch.. some refer to .secret others to .password

===
I can fix this but what is the preference; *.secret or *.password?

[stefanettim]

Hi,

"ordssrvs.database.oracle.com"
Let's consider OrdsSrvs controller only

"what is the preference; .secret or .password?"
they are two different things:

• "secret" is the k8s resource that contains passwords, like a wallet
• "password" is the string containing the actual password

The OrdsSrvs controller reads "secrets" and sets "passwords" for ords_init.sh script.

"CRD defines: poolSettings: - db.secret: ..."
That's correct, these are k8s secrets that contain passwords.

"apis/database/v4"
I cannot find "db.password" in apis/database/v4/ordssrvs_types.go

"commons/database/constants.go"
SetupORDSCMD and SetApexUsers constants are not used by ordssrvs controller

"ords/ords_init.sh"
set_secret "${pool_name}" "db.password" "${config["dbsecret"]}"
yes, here we have a mismatch, dbsecret is a password, not a secret.
I would call it db.password, like the ords key

"ords/runOrdsSSL.sh"
this is not part of ordssrvs controller and It will be removed on 2.0 release.

BR, Marco

[marcstef-oracle]

We found no mismatches in the documentation of OrdsSrvs.
The naming convention within ords_init.sh will be rectified in the upcoming release.

Regards,
Marco