Skip to content

Update build containers #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025
Merged

Update build containers #2477

merged 5 commits into from
Jun 3, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 1, 2025

What does this implement/fix?

Accompanies pi-hole/docker-base-images#103 and attempts to fix the RISCV64 build failing since GHA updated their runner from

to

Changes


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

DL6ER added 3 commits June 1, 2025 07:53
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
@yubiuser
Copy link
Member

yubiuser commented Jun 1, 2025

You could add workflow dispatch inputs to allow to set TRACE on Github action as well.

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onworkflow_dispatchinputs

@DL6ER DL6ER force-pushed the special/CI_development branch from 63e5ea5 to 47a0d7f Compare June 1, 2025 16:21
@dschaper
Copy link
Member

dschaper commented Jun 2, 2025

Does the dockerfile changes from #2483 need to be included in this PR?

Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@DL6ER DL6ER marked this pull request as ready for review June 2, 2025 17:34
@DL6ER DL6ER requested a review from a team as a code owner June 2, 2025 17:34
Signed-off-by: DL6ER <dl6er@dl6er.de>
dschaper
dschaper previously approved these changes Jun 2, 2025
@dschaper dschaper requested a review from a team June 2, 2025 19:14
@dschaper
Copy link
Member

dschaper commented Jun 2, 2025

PR is good to go. Check #2461 to see if it should be merged prior to this PR going in.

@yubiuser
Copy link
Member

yubiuser commented Jun 3, 2025

This targets master. Is this intended?

@DL6ER DL6ER changed the base branch from master to development June 3, 2025 16:04
@DL6ER DL6ER dismissed dschaper’s stale review June 3, 2025 16:04

The base branch was changed.

@DL6ER
Copy link
Member Author

DL6ER commented Jun 3, 2025

No, I changed the base branch. Assuming the approval still holds. #2461 can wait.

@DL6ER DL6ER merged commit 522482f into development Jun 3, 2025
20 checks passed
@DL6ER DL6ER mentioned this pull request Jun 4, 2025
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v6-2-2-released/80447/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants