Skip to content

Update ftl-build container #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2025
Merged

Update ftl-build container #103

merged 5 commits into from
Jun 1, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 24, 2025

What does this implement/fix?

We add the dnspython package to be able to write more complicated DNS tests on the CI.
Furthermore, we

  • update the mbedtls library to its most recent version,
  • update the entire build container to alpine:3.22 released yesterday, and
  • use arm runners for arm targets to drastically improve build time:

This PR

this PR
(ignore the RISCV64 job)

master

branch master


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team January 24, 2025 16:29
@yubiuser
Copy link
Member

Compiling readline failed.

@DL6ER
Copy link
Member Author

DL6ER commented Jan 24, 2025

I restarted the armv8 build a few times now, it fails in various different libraries with a serious compiler issues. Seems the most recent stable (!) Alpine release is having issues on armv8.

@DL6ER DL6ER force-pushed the ftl-build/dnspython branch 2 times, most recently from 14fa1cc to 0a16422 Compare January 24, 2025 18:14
@dschaper
Copy link
Member

Running Actions on this branch at https://github.com/pi-hole/docker-base-images/actions/runs/14956211804

@dschaper
Copy link
Member

The failing or timeout builds all fail at this step:

 #14 1233.8 195/202 ✓ Internal IP -> name resolution works (UDP IPv4)
#14 1234.5 196/202 ✓ Internal IP -> name resolution works (UDP IPv6)
#14 1235.2 197/202 ✓ Internal IP -> name resolution works (TCP IPv4)
#14 1236.0 198/202 ✓ Internal IP -> name resolution works (TCP IPv6)

@DL6ER
Copy link
Member Author

DL6ER commented May 14, 2025

The step following on this is the API verification which is quite an extensive test. However, even with CPU emulation it should take at most a few seconds. But it is definitely already an improvement...

@DL6ER
Copy link
Member Author

DL6ER commented May 17, 2025

@dschaper how have you been able to re-trigger a build here (were you)? I just saw that the builds are a long time ago and it seems there is no option to try again now

grafik

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER changed the title Add python package dnspython into build container Update ftl-build container May 17, 2025
@dschaper
Copy link
Member

dschaper commented May 17, 2025

Manual trigger on the workflow, pick the branch from the PR.

image

@DL6ER
Copy link
Member Author

DL6ER commented May 17, 2025

I decided to push another commit to this PR, the non-emulated have already finished running. Keeping my fingers crossed

@dschaper
Copy link
Member

@DL6ER DL6ER force-pushed the ftl-build/dnspython branch from 01b2edb to ab5a879 Compare May 31, 2025 11:30
…d on pull request for foreign origins

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER force-pushed the ftl-build/dnspython branch 2 times, most recently from c5f37af to 365de20 Compare May 31, 2025 16:28
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER force-pushed the ftl-build/dnspython branch from 365de20 to e5e97f2 Compare May 31, 2025 16:30
@DL6ER DL6ER mentioned this pull request Jun 1, 2025
5 tasks
@DL6ER
Copy link
Member Author

DL6ER commented Jun 1, 2025

@yubiuser @dschaper Build containers fixed. Follow-up PR to get the necessary changes into FTL is pi-hole/FTL#2477 once we have a tag here and can it include over there. The PR description has been updated to reflect the changes in this PR

@dschaper dschaper merged commit 61a5394 into master Jun 1, 2025
10 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants