Skip to content

feat: convert package to ESM-only #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: convert package to ESM-only #143

wants to merge 9 commits into from

Conversation

wolfy1339
Copy link

BREAKING CHANGE: This package is now ESM only

@wolfy1339 wolfy1339 added the enhancement New feature or request label Apr 4, 2025
@wolfy1339 wolfy1339 requested a review from Copilot April 4, 2025 22:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

test/index.test.js:5

  • In ESM modules, local imports generally require explicit file extensions. Consider changing the import to "../index.js" to avoid potential resolution issues.
import { createLambdaFunction, Probot, ProbotOctokit } from "../index";

index.js:1

  • For consistency with other local ESM imports (e.g., in lambda-function.js), including an explicit file extension ("./lambda-function.js") could help ensure proper module resolution.
import lambdaFunction from "./lambda-function";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant