Skip to content

fix: correctly handle base64 encoded message body (ApiGateway) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2020
Merged

fix: correctly handle base64 encoded message body (ApiGateway) #33

merged 1 commit into from
Jan 19, 2020

Conversation

nimrodolev
Copy link
Contributor

This solves #32

@JasonEtco JasonEtco closed this Jan 19, 2020
@JasonEtco
Copy link
Member

I pressed the wrong button 😅

@JasonEtco JasonEtco reopened this Jan 19, 2020
JasonEtco
JasonEtco approved these changes Jan 19, 2020
View reviewed changes
Copy link
Member

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - looks good! ✨

@JasonEtco JasonEtco merged commit e944ab6 into probot:master Jan 19, 2020
@nimrodolev
Copy link
Contributor Author

Hey, thanks for the quick merge 🙏
Just out of interest, I see there's no CI setup - when do you usually ship new versions to npm?

@nimrodolev nimrodolev deleted the fix/32-handle-base64-encoded-body branch January 20, 2020 13:17
@JasonEtco JasonEtco mentioned this pull request Jan 27, 2020
Closed
@JasonEtco
Copy link
Member

JasonEtco commented Jan 27, 2020 •
edited
Loading

Sorry about the wait @nimrodolev; version 0.5.0 is now published! This package isn't super well cared for so we don't have a schedule or any publishing automation 😓

@nimrodolev
Copy link
Contributor Author

Thanks for the update, @JasonEtco!
Would you be open for a PR with Travis integration for automatic publishing to NPM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonEtco JasonEtco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimrodolev @JasonEtco