Skip to content

refactor: replace find exercise job with reusable workflow #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

FidelusAleksander
Copy link
Contributor

@FidelusAleksander FidelusAleksander commented Mar 28, 2025

Summary

The current workflow was checking for only 1 issue (the exercise issue)

 const issues = await github.rest.issues.listForRepo({
        owner: context.repo.owner,
        repo: context.repo.repo,
        state: 'open',
        per_page: 1 <- HERE
      });

Which caused an issue when one of the users tried to open a bug report but opened the issue on their copy of the exercise repository.
image

Changes

Use the find-exercise-issue workflow from exercise-toolkit

Closes: #18

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the “find exercise” steps from multiple workflows to use a centralized reusable workflow from exercise-toolkit.

  • Replaces duplicated GitHub Script logic with a reusable workflow.
  • Standardizes the “Find Exercise Issue” job across all workflows.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/4b-copilot-on-github.yml Uses reusable workflow for finding the exercise issue
.github/workflows/4-copilot-edits.yml Uses reusable workflow for finding the exercise issue
.github/workflows/3b-copilot-agent-mode.yml Uses reusable workflow for finding the exercise issue
.github/workflows/2-first-introduction.yml Uses reusable workflow for finding the exercise issue
.github/workflows/1-preparing.yml Uses reusable workflow for finding the exercise issue

@FidelusAleksander FidelusAleksander added the bug Something isn't working label Mar 28, 2025
@FidelusAleksander FidelusAleksander merged commit 4f17cb3 into skills:main Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

[Bug] Can't get past Exercise 1
2 participants