Skip to content

feat: initial draft of the exercise #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

feat: initial draft of the exercise #1

merged 1 commit into from
Mar 27, 2025

Conversation

FidelusAleksander
Copy link
Contributor

Summary

Initial draft of the exercise

Changes

Closes:

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request sets up an initial draft for the extracurricular activities exercise by introducing the FastAPI backend, a static frontend, comprehensive documentation, and multi-step GitHub Actions workflows to guide participants through the exercise.

  • Introduces a FastAPI backend (src/app.py) providing activities data and signup functionality.
  • Implements a client-side script (src/static/app.js) to display activities and handle signups.
  • Adds detailed documentation and a series of GitHub Actions workflows and step files to drive the exercise flow.

Reviewed Changes

Copilot reviewed 16 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/static/app.js Implements DOM interaction for loading activities and signing up.
src/app.py Provides a simple FastAPI app with activity listing and signup.
src/README.md Documents the API endpoints for the school activities.
README.md Guides integration of MCP with GitHub Copilot for the exercise.
.github/workflows/* and .github/steps/* Define exercise steps and workflow automation using GitHub Actions.
Files not reviewed (4)
  • .devcontainer/devcontainer.json: Language not supported
  • .vscode/launch.json: Language not supported
  • src/static/index.html: Language not supported
  • src/static/styles.css: Language not supported

activity = activities[activity_name]

# Add student
activity["participants"].append(email)
Copy link
Preview

Copilot AI Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signup endpoint does not check whether the activity has already reached its maximum number of participants before adding a new signup. Consider verifying the available spots before appending the email.

Copilot uses AI. Check for mistakes.

@FidelusAleksander FidelusAleksander merged commit 56e0e30 into main Mar 27, 2025
2 of 3 checks passed
@FidelusAleksander FidelusAleksander deleted the dev branch March 27, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant