Move from TSLint (deprecated) to ESLint + Prettier.

Author: rolftimmermans

.eslintrc

@@ -0,0 +1,29 @@
+{
+  "parser": "@typescript-eslint/parser",
+  "plugins": [
+    "@typescript-eslint",
+    "prettier"
+  ],
+  "extends": [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/eslint-recommended",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:prettier/recommended",
+    "prettier/@typescript-eslint"
+  ],
+  "rules": {
+    "prettier/prettier": "error",
+    "no-fallthrough": "error",
+    "no-inner-declarations": "off",
+    "no-prototype-builtins": "off",
+    "no-unused-expressions": "warn",
+    "prefer-const": ["warn", {"destructuring": "all"}],
+    "@typescript-eslint/no-empty-interface": "off",
+    "@typescript-eslint/no-non-null-assertion": "off",
+    "@typescript-eslint/no-use-before-define": "off",
+    "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-unused-vars": "off",
+    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/quotes": ["error", "double"],
+  }
+}

.prettierrc

@@ -0,0 +1,11 @@
+{
+  "arrowParens": "avoid",
+  "bracketSpacing": false,
+  "endOfLine": "lf",
+  "printWidth": 80,
+  "proseWrap": "always",
+  "tabWidth": 2,
+  "trailingComma": "all",
+  "semi": false,
+  "singleQuote": false
+}

examples/majordomo/broker.ts

@@ -1,4 +1,3 @@
-/* tslint:disable: no-console */
 import {Router} from "zeromq"
 
 import {Service} from "./service"
@@ -10,7 +9,7 @@ export class Broker {
   services: Map<string, Service> = new Map()
   workers: Map<string, Buffer> = new Map()
 
-  constructor(address: string = "tcp://127.0.0.1:5555") {
+  constructor(address = "tcp://127.0.0.1:5555") {
     this.address = address
   }
 
@@ -21,14 +20,14 @@ export class Broker {
     const loop = async () => {
       for await (const [sender, blank, header, ...rest] of this.socket) {
         switch (header.toString()) {
-        case Header.Client:
-          this.handleClient(sender, ...rest)
-          break
-        case Header.Worker:
-          this.handleWorker(sender, ...rest)
-          break
-        default:
-          console.error(`invalid message header: ${header}`)
+          case Header.Client:
+            this.handleClient(sender, ...rest)
+            break
+          case Header.Worker:
+            this.handleWorker(sender, ...rest)
+            break
+          default:
+            console.error(`invalid message header: ${header}`)
         }
       }
     }
@@ -50,22 +49,28 @@ export class Broker {
 
   handleWorker(worker: Buffer, type?: Buffer, ...rest: Buffer[]) {
     switch (type && type.toString()) {
-    case Message.Ready:
-      const [service] = rest
-      this.register(worker, service)
-      break
-    case Message.Reply:
-      const [client, blank, ...rep] = rest
-      this.dispatchReply(worker, client, ...rep)
-      break
-    case Message.Heartbeat:
-      /* Heartbeats not implemented yet. */
-      break
-    case Message.Disconnect:
-      this.deregister(worker)
-      break
-    default:
-      console.error(`invalid worker message type: ${type}`)
+      case Message.Ready: {
+        const [service] = rest
+        this.register(worker, service)
+        break
+      }
+
+      case Message.Reply: {
+        const [client, blank, ...rep] = rest
+        this.dispatchReply(worker, client, ...rep)
+        break
+      }
+
+      case Message.Heartbeat:
+        /* Heartbeats not implemented yet. */
+        break
+
+      case Message.Disconnect:
+        this.deregister(worker)
+        break
+
+      default:
+        console.error(`invalid worker message type: ${type}`)
     }
   }
 

examples/majordomo/index.ts

@@ -1,11 +1,10 @@
-/* tslint:disable: no-console */
 import {Request} from "zeromq"
 
 import {Broker} from "./broker"
 import {Worker} from "./worker"
 
 async function sleep(msec: number) {
-  return new Promise((resolve) => setTimeout(resolve, msec))
+  return new Promise(resolve => setTimeout(resolve, msec))
 }
 
 class TeaWorker extends Worker {
@@ -28,13 +27,12 @@ class CoffeeWorker extends Worker {
 
 const broker = new Broker()
 
-const workers = [
-  new TeaWorker(),
-  new CoffeeWorker(),
-  new TeaWorker(),
-]
+const workers = [new TeaWorker(), new CoffeeWorker(), new TeaWorker()]
 
-async function request(service: string, ...req: string[]): Promise<undefined | Buffer[]> {
+async function request(
+  service: string,
+  ...req: string[]
+): Promise<undefined | Buffer[]> {
   const socket = new Request({receiveTimeout: 2000})
   socket.connect(broker.address)
 
@@ -71,7 +69,7 @@ async function main() {
   broker.stop()
 }
 
-main().catch((err) => {
+main().catch(err => {
   console.error(err)
   process.exit(1)
 })

examples/majordomo/service.ts

@@ -1,4 +1,3 @@
-/* tslint:disable: no-console */
 import {Router} from "zeromq"
 
 import {Header, Message} from "./types"
@@ -24,16 +23,10 @@ export class Service {
 
     console.log(
       `dispatching '${this.name}' ` +
-      `${client.toString("hex")} <- rep ${worker.toString("hex")}`,
+        `${client.toString("hex")} <- rep ${worker.toString("hex")}`,
     )
 
-    await this.socket.send([
-      client,
-      null,
-      Header.Client,
-      this.name,
-      ...rep,
-    ])
+    await this.socket.send([client, null, Header.Client, this.name, ...rep])
 
     this.dispatchPending()
   }
@@ -46,7 +39,7 @@ export class Service {
 
       console.log(
         `dispatching '${this.name}' ` +
-        `${client.toString("hex")} req -> ${worker.toString("hex")}`,
+          `${client.toString("hex")} req -> ${worker.toString("hex")}`,
       )
 
       await this.socket.send([
@@ -62,13 +55,17 @@ export class Service {
   }
 
   register(worker: Buffer) {
-    console.log(`registered worker ${worker.toString("hex")} for '${this.name}'`)
+    console.log(
+      `registered worker ${worker.toString("hex")} for '${this.name}'`,
+    )
     this.workers.set(worker.toString("hex"), worker)
     this.dispatchPending()
   }
 
   deregister(worker: Buffer) {
-    console.log(`deregistered worker ${worker.toString("hex")} for '${this.name}'`)
+    console.log(
+      `deregistered worker ${worker.toString("hex")} for '${this.name}'`,
+    )
     this.workers.delete(worker.toString("hex"))
     this.dispatchPending()
   }

examples/majordomo/worker.ts

@@ -1,14 +1,13 @@
-/* tslint:disable: no-console */
 import {Dealer} from "zeromq"
 
 import {Header, Message} from "./types"
 
 export class Worker {
   address: string
-  service: string = ""
+  service = ""
   socket: Dealer = new Dealer()
 
-  constructor(address: string = "tcp://127.0.0.1:5555") {
+  constructor(address = "tcp://127.0.0.1:5555") {
     this.address = address
     this.socket.connect(address)
   }
@@ -17,11 +16,17 @@ export class Worker {
     await this.socket.send([null, Header.Worker, Message.Ready, this.service])
 
     const loop = async () => {
-      for await (const [blank1, header, type, client, blank2, ...req] of this.socket) {
+      for await (const [blank1, header, type, client, blank2, ...req] of this
+        .socket) {
         const rep = await this.process(...req)
         try {
           await this.socket.send([
-            null, Header.Worker, Message.Reply, client, null, ...rep,
+            null,
+            Header.Worker,
+            Message.Reply,
+            client,
+            null,
+            ...rep,
           ])
         } catch (err) {
           console.error(`unable to send reply for ${this.address}`)
@@ -34,7 +39,12 @@ export class Worker {
 
   async stop() {
     if (!this.socket.closed) {
-      await this.socket.send([null, Header.Worker, Message.Disconnect, this.service])
+      await this.socket.send([
+        null,
+        Header.Worker,
+        Message.Disconnect,
+        this.service,
+      ])
       this.socket.close()
     }
   }

examples/queue/index.ts

@@ -1,4 +1,3 @@
-/* tslint:disable: no-console */
 import {Dealer} from "zeromq"
 
 import {Queue} from "./queue"
@@ -25,7 +24,7 @@ async function main() {
   }
 }
 
-main().catch((err) => {
+main().catch(err => {
   console.error(err)
   process.exit(1)
 })

examples/queue/queue.ts

@@ -4,9 +4,9 @@ export class Queue {
   queue: any[] = []
   socket: Socket
   max: number
-  sending: boolean = false
+  sending = false
 
-  constructor(socket: Socket, max: number = 100) {
+  constructor(socket: Socket, max = 100) {
     this.socket = socket
     this.max = max
   }

examples/threaded-worker/index.ts

@@ -1,4 +1,3 @@
-/* tslint:disable: no-console */
 import {Processor} from "./processor"
 
 async function main() {
@@ -17,10 +16,10 @@ async function transform(processor: Processor, input: string) {
   const end = process.hrtime(start)
 
   console.log(`received output '${input}' -> '${output}' in ${end[0]}s`)
-  console.log(`---`)
+  console.log("---")
 }
 
-main().catch((err) => {
+main().catch(err => {
   console.error(err)
   process.exit(1)
 })

examples/threaded-worker/processor.ts

@@ -1,4 +1,3 @@
-/* tslint:disable: no-console */
 import {cpus} from "os"
 import {Publisher, Pull, Push} from "zeromq"
 
@@ -16,33 +15,31 @@ export class Processor {
 
   constructor(threads: number = cpus().length) {
     console.log(`starting ${threads} worker threads`)
-    console.log(`---`)
+    console.log("---")
 
     this.threads = threads
     this.init = Promise.all([
       this.input.bind("inproc://input"),
       this.output.bind("inproc://output"),
       this.signal.bind("inproc://signal"),
-      new Promise((resolve) => setTimeout(resolve, 100)),
+      new Promise(resolve => setTimeout(resolve, 100)),
     ])
 
-    this.exit = Promise.all([
-      ThreadedWorker.spawn(this.threads),
-    ])
+    this.exit = Promise.all([ThreadedWorker.spawn(this.threads)])
   }
 
   async process(str: string): Promise<string> {
     await this.init
 
     const input = str.split("")
     for (const req of input.entries()) {
-      await this.input.send(req.map((pt) => pt.toString()))
+      await this.input.send(req.map(pt => pt.toString()))
     }
 
     const output: string[] = Array.from({length: input.length})
     for await (const [pos, res] of this.output) {
       output[parseInt(pos.toString(), 10)] = res.toString()
-      if (output.every((el) => el !== undefined)) break
+      if (output.every(el => el !== undefined)) break
     }
 
     return output.join("")

examples/threaded-worker/threaded-worker.ts

@@ -1,4 +1,3 @@
-/* tslint:disable: no-console */
 import {Worker} from "worker_threads"
 import * as zmq from "zeromq"
 
@@ -12,7 +11,7 @@ export class ThreadedWorker {
           new ThreadedWorker().run()
         `
 
-        new Worker(src, {eval: true}).on("exit", (code) => {
+        new Worker(src, {eval: true}).on("exit", code => {
           if (code === 0) {
             resolve()
           } else {
@@ -23,7 +22,7 @@ export class ThreadedWorker {
     })
 
     await Promise.all(workers)
-    console.log(`all workers stopped`)
+    console.log("all workers stopped")
   }
 
   /* Queue only 1 incoming message. */
@@ -81,9 +80,9 @@ export class ThreadedWorker {
 
     for (let i = 0; i < 200000001; i++) {
       if (char >= 65 && char <= 90) {
-        char = (char - 65 + this.shift) % 26 + 65
+        char = ((char - 65 + this.shift) % 26) + 65
       } else if (char >= 97 && char <= 122) {
-        char = (char - 97 + this.shift) % 26 + 97
+        char = ((char - 97 + this.shift) % 26) + 97
       }
     }