Skip to content

llama4 ckpt conversion #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

llama4 ckpt conversion #1816

wants to merge 1 commit into from

Conversation

aireenmei
Copy link
Collaborator

@aireenmei aireenmei commented Jun 10, 2025 •
edited
Loading

Description

Joint by @aireenmei and @hengtaoguo .
Add ckpt conversion for llama4 vision model from hf to maxtext.

Tests

Verified in #1809

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@aireenmei aireenmei force-pushed the aireen/llama4_ckpt_conversion branch from 4c2fd98 to 3b1d43d Compare June 10, 2025 20:21
@aireenmei aireenmei force-pushed the aireen/llama4_ckpt_conversion branch from 8981d6d to 4ff7e82 Compare June 20, 2025 19:03
@aireenmei aireenmei changed the title [WIP] llama4 ckpt conversion llama4 ckpt conversion Jun 20, 2025
@aireenmei aireenmei marked this pull request as ready for review June 20, 2025 19:08
hengtaoguo
hengtaoguo approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@hengtaoguo hengtaoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Aireen for the great work!

I just checked the vision_config between Scout/Maverick, and they seem to be the same. It appears we can reuse the same scripts for Maverick conversion too.

@aireenmei aireenmei force-pushed the aireen/llama4_ckpt_conversion branch from 4ff7e82 to f589d21 Compare June 20, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengtaoguo hengtaoguo hengtaoguo approved these changes

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@gagika gagika Awaiting requested review from gagika gagika is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@yangyuwei yangyuwei Awaiting requested review from yangyuwei yangyuwei is a code owner

@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC is a code owner

@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@hengtaoguo hengtaoguo

@gagika gagika

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aireenmei @hengtaoguo @gagika