-
Notifications
You must be signed in to change notification settings - Fork 387
Upgrade dependencies (now supports and defaults to Python 3.12 and Ubuntu 24.04) #1826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @SamuelMarks. I assume we will also need to make changes in constraints_gpu.txt
and requirements_with_jax_ai_image.txt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to test this setup with a MaxText workload/base model?
@bvandermoon Sure happy to update those also. @shralex was talking about making 3.12 the new default. How about this:
(not sure the process for upgrading Can upgrade them all in this PR or separate it out into multiple. Let me know 🤗 |
…ure Python 3.13 support (but remove its classifier as it isn't supported yet) ; [*] Upgrade from `3.10` to `3.12` ; upgrade from `22.04` to `24.04`
# Conflicts: # setup.py
# Conflicts: # requirements.txt
Description
Upgrade dependencies
python3 -m pip install -r requirements.txt
with no special flags(I also sorted the dependencies so it's easier to debug and add/remove deps in the future)
FWIW Python 3.13 cannot yet be supported, but this patch did make the dependencies installable:
Tests
N/A
Checklist
Before submitting this PR, please make sure (put X in square brackets):