Small improvements to naming / structure in input_pipeline_interface.py #1845
+160
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuojCheng
changed the title
NuojCheng
force-pushed
the
chengnuojin/input_pipeline
branch
4 times, most recently
from
99e1569 to
14c16f1
Compare
NuojCheng
changed the title
NuojCheng
requested review from
aireenmei,
SurbhiJainUSC and
richjames0
as code owners
There was a problem hiding this comment.
Maybe name this module as synthethic_data_processing.py
NuojCheng
force-pushed
the
chengnuojin/input_pipeline
branch
from
8728f1a to
de5ef9c
Compare
NuojCheng
force-pushed
the
chengnuojin/input_pipeline
branch
from
a4bc416 to
dd92595
Compare
aireenmei
reviewed
Jun 25, 2025
| assert config.packing, "c4_mlperf dataloader only works with packing. For padded version, use tfds dataloader" | ||
| train_iterator, eval_iterator = dataset_type_to_train_eval_iterator[config.dataset_type] | ||
| else: | ||
| max_logging.log(f"WARNING: '{config.dataset_type}' is not a supported dataset type." \ |
There was a problem hiding this comment.
When user specify dataset_type=synthetic, this WARNING message will be confusing. We can exclude that case.
There was a problem hiding this comment.
When dataset_type=synthetic, it should not incur this warning message as it exits in line 64.
There was a problem hiding this comment.
I see. Sorry I missed that. Thanks!
aireenmei
approved these changes
Jun 25, 2025
| assert config.packing, "c4_mlperf dataloader only works with packing. For padded version, use tfds dataloader" | ||
| train_iterator, eval_iterator = dataset_type_to_train_eval_iterator[config.dataset_type] | ||
| else: | ||
| max_logging.log(f"WARNING: '{config.dataset_type}' is not a supported dataset type." \ |
There was a problem hiding this comment.
I see. Sorry I missed that. Thanks!
SurbhiJainUSC
approved these changes
Jun 25, 2025
NuojCheng
force-pushed
the
chengnuojin/input_pipeline
branch
from
dd92595 to
58af99b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TL;DR: Re-organize input_pipeline_interphase.py for better readability
Following changes are made:
FIXES: b/421596013
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):