Skip to content

[test optimization] Improve flakiness of performance overhead test #5898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025

Conversation

juan-fernandez
Copy link
Collaborator

What does this PR do?

Reduce flakiness of performance overhead test.

Motivation

Sometimes the script fails because jobs is undefined. This is likely due to a malformed response from github: https://github.com/DataDog/dd-trace-js/actions/runs/15613751784/job/43981048645

Copy link

github-actions bot commented Jun 16, 2025

Overall package size

Self size: 9.66 MB
Deduped: 101.62 MB
No deduping: 102.14 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.8.2 | 9.56 MB | 9.93 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.73%. Comparing base (a8b7185) to head (78764fd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5898   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files         462      462           
  Lines       19914    19914           
=======================================
  Hits        16078    16078           
  Misses       3836     3836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juan-fernandez juan-fernandez marked this pull request as ready for review June 16, 2025 09:59
@juan-fernandez juan-fernandez requested review from a team as code owners June 16, 2025 09:59
@pr-commenter
Copy link

pr-commenter bot commented Jun 16, 2025

Benchmarks

Benchmark execution time: 2025-06-17 10:47:06

Comparing candidate commit 78764fd in PR branch juan-fernandez/fix-benchmark-e2e-ci with baseline commit a8b7185 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1273 metrics, 50 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 16, 2025

Datadog Report

Branch report: juan-fernandez/fix-benchmark-e2e-ci
Commit report: 5ba5663
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1257 Passed, 0 Skipped, 22m 0.35s Total Time

rochdev
rochdev previously approved these changes Jun 16, 2025
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this to a loop that has a maximum count of e.g., 720 (maximum run time is one hour). That way the code is likely easier to read:

const pollTimeInMS = 5000
for (let run = 0: run < 60 * 60 * 1000; run += pollTimeInMS) {
  // do stuff
  if (endCodition) {
    return
  }
  await timers.promises.setTimeout(pollTimeInMS)
}

@juan-fernandez
Copy link
Collaborator Author

Could we change this to a loop that has a maximum count of e.g., 720 (maximum run time is one hour). That way the code is likely easier to read:

const pollTimeInMS = 5000
for (let run = 0: run < 60 * 60 * 1000; run += pollTimeInMS) {
  // do stuff
  if (endCodition) {
    return
  }
  await timers.promises.setTimeout(pollTimeInMS)
}

cleaned it up in 78764fd

@juan-fernandez juan-fernandez requested a review from BridgeAR June 17, 2025 10:50
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup :)

@BridgeAR BridgeAR merged commit 9b3d7fd into master Jun 17, 2025
536 checks passed
@BridgeAR BridgeAR deleted the juan-fernandez/fix-benchmark-e2e-ci branch June 17, 2025 11:40
@dd-trace-js dd-trace-js bot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants