Remove SSI profiler heuristics telemetry #5903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 9.73 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.8.2 | 9.56 MB | 9.93 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5903 +/- ##
==========================================
- Coverage 79.53% 78.98% -0.56%
==========================================
Files 477 471 -6
Lines 20390 20156 -234
==========================================
- Hits 16217 15920 -297
- Misses 4173 4236 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 1258 Passed, 0 Skipped, 21m 14.09s Total Time |
BenchmarksBenchmark execution time: 2025-06-25 09:32:52 Comparing candidate commit 7199ba7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1273 metrics, 50 unstable metrics. |
szegedi
force-pushed
the
szegedi/remove-ssi-telemetry
branch
3 times, most recently
from
7f68b9a to
34888c3
Compare
szegedi
force-pushed
the
szegedi/remove-ssi-telemetry
branch
from
be3d833 to
7199ba7
Compare
szegedi
changed the title
nsavoire
reviewed
Jun 25, 2025
| @@ -24,9 +24,7 @@ function exporterFromURL (url) { | |||
| ? 'manual' | |||
| : profilingEnabled === 'auto' | |||
| ? 'auto' | |||
| : injectionEnabled.includes('profiling') | |||
There was a problem hiding this comment.
It was not even correct (profiling instead of profiler) 😅
nsavoire
approved these changes
Jun 25, 2025
dd-trace-js bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
* Don't emit SSI heuristics telemetry metrics anymore * Do not handle DD_INJECTION_ENABLED=profiler
Merged
szegedi
added a commit
that referenced
this pull request
Jul 1, 2025
* Don't emit SSI heuristics telemetry metrics anymore * Do not handle DD_INJECTION_ENABLED=profiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DD_INJECTION_ENABLED=profiler, as it was never implemented in the injection platform and is superseded by Stable APM Configuration through upgrade(tracer): Support libdatadog's library_config module #5126.(These look unrelated, but aren't, both were initial SSI features and the env var did also affect SSI profiler operation.)
Motivation
SSI heuristics telemetry is not used anymore, and
DD_INJECTION_ENABLED=profilernever obtained support in the injection platform , thus removing the code for these unused features reduces maintenance burden.Additional Notes
Jira: PROF-11969