-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[DJM-812] Airflow task logs child pipeline #20233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DJM-812] Airflow task logs child pipeline #20233
Conversation
4394592
to
9fb4333
Compare
Review from baturalp-dd is dismissed. Related teams and files:
- logs-backend
- airflow/assets/logs/airflow.yaml
- logs-integrations-reviewers
- airflow/assets/logs/airflow.yaml
👋 Thanks for the review ! I just flipped the |
Hi @baturalp-dd, would you mind taking a look again please? I'm sorry I dismissed your review with the changes I made after checking the deployed pipeline on staging. |
Hi @baturalp-dd , gentle bump on this 🙇 |
7f783d4
to
b8ada63
Compare
Review from baturalp-dd is dismissed. Related teams and files:
- logs-backend
- airflow/assets/logs/airflow.yaml
- airflow/assets/logs/airflow_tests.yaml
- logs-integrations-reviewers
- airflow/assets/logs/airflow.yaml
- airflow/assets/logs/airflow_tests.yaml
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
adrien.boitreaud@datadoghq.com unqueued this merge request |
/merge -c |
View all feedbacks in Devflow UI.
|
What does this PR do?
This PR updates the Airflow integration logs pipeline to extract
dag_id
,run_id
, andtask_id
from the dirname tag. Extraction is performed in a children subpipeline, which query checks for the presence ofdag_id
indirname
tag so that it's guaranteed that pipeline will find the attributes to be extracted.Motivation
Airflow DJM traces to logs correlation is made on
dag_id
,run_id
, andtask_id
attributes so they need to be present on the logs. See correlation logic here.Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged