[DBMON-5463] Switch sql index query resolution over to a static version check #20514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-weaver
commented
Jun 13, 2025
| @@ -169,8 +167,7 @@ def _cursor_run(self, cursor, query, params=None): | |||
| @tracked_method(agent_check_getter=agent_check_getter) | |||
| def _fetch_database_data(self, cursor, start_time, db_name): | |||
| tables = self._get_tables(db_name, cursor) | |||
| tables_chunks = list(get_list_chunks(tables, self.TABLES_CHUNK_SIZE)) | |||
| for tables_chunk in tables_chunks: | |||
| for tables_chunk in get_list_chunks(tables, self.TABLES_CHUNK_SIZE): | |||
There was a problem hiding this comment.
get_list_chunks is a generator function that yields chunks of TABLES_CHUNK_SIZE lists. This is a tiny refactor that will avoid immediately generating a new list of chunk lists and instead generate the chunks from the tables list on each loop
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
azhou-datadog
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoids a query to
INFORMATION_SCEMA.COLUMNSthat's currently made when schema collection is enabled. This query currently gets executed one time per 500 tables in a schema per check run to determine if a column exists for a subsequent query for index usage information. TheEXPRESSIONcolumn was added in mysql 8.0.13 as noted in information_schema.columns docs and MariaDB does not support this so we can statically check the version and flavor to determine which query we should runMotivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged